Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Automatic release #223

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Introduce Automatic release #223

wants to merge 14 commits into from
+130 −2

Conversation

wakwak3125
Copy link

@wakwak3125 wakwak3125 commented Feb 8, 2017 •
edited
Loading

Issue

Overview (Required)

Details are written at #222

  • Introduce Firebase Crash Report plugin
  • Create deploy shell.
  • Create GradleTask.
  • Create README
  • Upload mapping file with apk
  • Add Link to fastlane/supply

Links

@konifar
Copy link
Contributor

konifar commented Feb 8, 2017

When I can review, please let me know 😉

@wakwak3125
Copy link
Author

@konifar I got it 👍

jmatsu
jmatsu reviewed Feb 9, 2017
View reviewed changes
.gitignore
@@ -36,6 +36,7 @@ captures/
*.iml
.idea/*
!.idea/codeStyleSettings.xml
.idea/
Copy link
Contributor

@jmatsu jmatsu Feb 9, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JFYI, you can use git update-index --skip-worktree .idea/$FILENAME to ignore git-controlled files with keeping changes. 😃

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmatsu THX! I did't know about that...👽

gfx
gfx reviewed Feb 12, 2017
View reviewed changes
.idea/codeStyleSettings.xml Outdated
@@ -1,387 +0,0 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove codeStyleSettings. It is inevitable to fix code style.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK! I'll keep it 👍

@wakwak3125 wakwak3125 changed the title [WIP] Introduce Automatic release Introduce Automatic release Feb 14, 2017
@wakwak3125
Copy link
Author

@konifar Sorry for delayed... Could you please review this PR ?
If you have any questions, suggestions, or requests feel free to ask me 👍
I'll do my best.

@konifar
Copy link
Contributor

konifar commented Feb 14, 2017

@wakwak3125 Sure! Thanks! 👍

konifar
konifar reviewed Feb 14, 2017
View reviewed changes
app/build.gradle
@@ -4,8 +4,10 @@ apply plugin: 'jacoco'
apply plugin: 'com.android.application'
apply plugin: 'me.tatarka.retrolambda'
apply plugin: 'kotlin-android'
apply plugin: 'com.google.firebase.firebase-crash'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question 🙋
Why is this necessary?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can upload the mapping file to FirebaseCrash.
But, I fogot to introduce this to deploy process.
I'll fix it tomorrow.

konifar
konifar reviewed Feb 14, 2017
View reviewed changes
README_AUTOMATED_RELEASE.md
gem install fastlane
```

## 2. Create Service Account at GooglePlayConsole.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙋
Is this section almost same with fastlane setup README? If so, I think it's enough to write the link url here.
What do you think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes right.
But there are many noise to read core sentences.
So I try to rewrite about setup sentences.
But now I think I should add original link of fastlane,'s one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But there are many noise to read core sentences.

Make sense.
I'm just afraid that it might be hard to follow latest setup info. But it's okay as it is! Thanks!

@konifar
Copy link
Contributor

konifar commented Feb 14, 2017

@wakwak3125 Commented some questions!

@wakwak3125
Copy link
Author

Thx!

@horie1024
Copy link
Contributor

Hi! This pull request is interesting for me😃
I think that it is better to put various script files in the scripts directory. What do you think?

scripts
    ├── bootstrap.sh
    ├── deploy2store.sh
    └── initsupply.sh

@konifar
Copy link
Contributor

konifar commented Feb 15, 2017

@horie1024 Cool. I agree with you.

@wakwak3125
Copy link
Author

@horie1024 @konifar
Thank you for your review! I applied that!
But I have one more task, so just moment please 🙏
Sorry for delayed!

@wakwak3125
Copy link
Author

@konifar Could you please set up Firebase Crash Report plugin?
Just download service account key and put that file to project root with file name serviceaccount.json.

This link will help you.
https://firebase.google.com/docs/crash/android?hl=en

@konifar
Copy link
Contributor

konifar commented Feb 15, 2017

@wakwak3125 Sure! Thanks. But I have to work another task today. Let me try tomorrow 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmatsu jmatsu jmatsu left review comments

@konifar konifar konifar left review comments

@gfx gfx gfx left review comments

Assignees
No one assigned
Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wakwak3125 @konifar @horie1024 @gfx @jmatsu @KeithYokoma