-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
实现内核通知链 notifier chain #316
Merged
fslongjin
merged 11 commits into
DragonOS-Community:master
from
ccrysisa:patch-notifier-chain
Aug 6, 2023
Merged
实现内核通知链 notifier chain #316
fslongjin
merged 11 commits into
DragonOS-Community:master
from
ccrysisa:patch-notifier-chain
Aug 6, 2023
+232
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fslongjin
requested changes
Aug 3, 2023
kernel/src/notifier/notifier.rs
Outdated
use core::ffi::c_void; | ||
|
||
/// @brief 通知链中注册的回调函数类型 | ||
type NotifierFnT = fn(Arc<NotifierBlock>, u64, *mut c_void) -> i32; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个我觉得不要用裸指针的c_void,这个不好。也许可把notifierblock弄成trait,具有2个方法
- call()
- priority()
kernel/src/notifier/notifier.rs
Outdated
/// return 返回最后一次回调函数的返回值 | ||
// TODO: 未加入 RCU 锁的操作? | ||
// TODO: 增加 NOTIFIER_STOP_MASK 相关功能 | ||
pub fn call_chain(&self, val: u64, v: *mut c_void, nr_to_call: i32, nr_calls: *mut i32) -> i32 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里不要这样写,我感觉不需要任何unsafe
ccrysisa
force-pushed
the
patch-notifier-chain
branch
from
August 4, 2023 09:46
1663877
to
38aa4c1
Compare
fslongjin
approved these changes
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.