Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Officially" disable SA1126 (PrefixCallsCorrectly) #997

Merged
merged 2 commits into from
Jul 19, 2015

Conversation

sharwell
Copy link
Member

Fixes #59

@sharwell sharwell added this to the 1.0.0 Alpha 11 milestone Jul 18, 2015
@sharwell sharwell changed the title Disable SA1126 (PrefixCallsCorrectly) "Officially" disable SA1126 (PrefixCallsCorrectly) Jul 18, 2015
@pdelvo
Copy link
Member

pdelvo commented Jul 18, 2015

The comments should probably include why it is not implemented by design. And Im looking for an automated way for the status page to detect this and maybe show the reason for it on the page. For me the easiest thing would be to add an attribute similar to the NoCodeFixAttribute.

@sharwell
Copy link
Member Author

@pdelvo I updated this based on your feedback

@pdelvo
Copy link
Member

pdelvo commented Jul 19, 2015

:shipit:

sharwell added a commit that referenced this pull request Jul 19, 2015
"Officially" disable SA1126 (PrefixCallsCorrectly)
@sharwell sharwell merged commit 7110aa5 into DotNetAnalyzers:master Jul 19, 2015
@sharwell sharwell deleted the disable-sa1126 branch July 19, 2015 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants