Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SA1135 to support file-scoped namespaces #3419

Merged
merged 2 commits into from
Dec 8, 2021

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Dec 8, 2021

Fixes #3415

@sharwell sharwell marked this pull request as draft December 8, 2021 19:42
@sharwell sharwell force-pushed the file-scoped-namespace branch from 334fe39 to 69a0700 Compare December 8, 2021 19:42
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #3419 (31cd1a5) into master (08588cd) will increase coverage by 0.02%.
The diff coverage is 93.61%.

@@            Coverage Diff             @@
##           master    #3419      +/-   ##
==========================================
+ Coverage   93.12%   93.15%   +0.02%     
==========================================
  Files        1041     1043       +2     
  Lines      111934   111978      +44     
  Branches     3971     3973       +2     
==========================================
+ Hits       104241   104312      +71     
+ Misses       6673     6645      -28     
- Partials     1020     1021       +1     

@sharwell sharwell force-pushed the file-scoped-namespace branch from 69a0700 to 751c49a Compare December 8, 2021 21:16
@sharwell sharwell force-pushed the file-scoped-namespace branch from 751c49a to 31cd1a5 Compare December 8, 2021 21:19
@sharwell sharwell marked this pull request as ready for review December 8, 2021 23:39
@sharwell sharwell merged commit 0b40032 into DotNetAnalyzers:master Dec 8, 2021
@sharwell sharwell deleted the file-scoped-namespace branch December 8, 2021 23:39
@sharwell sharwell added this to the 1.2-beta.next milestone Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SA1135 doesn't fire when using file-scoped namespace syntax
1 participant