Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ResxSourceGenerator for resource generation #3343

Merged
merged 7 commits into from
Apr 26, 2023
Merged

Use ResxSourceGenerator for resource generation #3343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bb0e8c0
Use ResxSourceGenerator for resource generation
sharwell Apr 5, 2021
f269ba9
Remove resx generated files from source control
sharwell Apr 28, 2021
da767f2
Merge remote-tracking branch 'DotNetAnalyzers/master' into resx-gener…
sharwell Mar 29, 2023
d80801a
Do not emit compiler generated files during CI builds
sharwell Mar 29, 2023
63aef01
Merge remote-tracking branch 'DotNetAnalyzers/master' into resx-gener…
sharwell Apr 8, 2023
6034a5f
Update to Microsoft.CodeAnalysis.ResxSourceGenerator 3.3.5-beta1.23205.2
sharwell Apr 8, 2023
d385cc9
Update to Microsoft.CodeAnalysis.ResxSourceGenerator 3.3.5-beta1.23223.2
sharwell Apr 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ OpenCover.Symbols/
.nuget/NuGet.exe
build/nuget/
*.log
StyleCop.Analyzers/StyleCop.Analyzers/Lightup/.generated/Microsoft.CodeAnalysis.ResxSourceGenerator.CSharp/

# Visual Studio performance tools
*.psess
Expand Down
6 changes: 5 additions & 1 deletion StyleCop.Analyzers/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,14 @@
<PackageReference Include="AsyncUsageAnalyzers" Version="1.0.0-alpha003" PrivateAssets="all" />
<PackageReference Include="DotNetAnalyzers.DocumentationAnalyzers" Version="1.0.0-beta.46" PrivateAssets="all" />
<PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.435" PrivateAssets="all" />
<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.5-beta1.23205.2" PrivateAssets="all" />
<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.5-beta1.23223.2" PrivateAssets="all" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.CodeStyle" Version="4.0.1" PrivateAssets="all" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis.ResxSourceGenerator" Version="3.3.5-beta1.23223.2" PrivateAssets="all" />
</ItemGroup>

<!-- C# Compiler -->
<ItemGroup>
<PackageReference Include="Microsoft.Net.Compilers.Toolset" Version="4.0.1" PrivateAssets="all" />
Expand Down
15 changes: 0 additions & 15 deletions StyleCop.Analyzers/Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<Project>

<ItemGroup>
<!-- Enable code generation for resource files -->
<CodeGenerationEmbeddedResource Include="@(EmbeddedResource)" Exclude="**\*.??-??.resx" />
<EmbeddedResource Update="@(CodeGenerationEmbeddedResource)" Generator="ResXFileCodeGenerator" />
</ItemGroup>

<!-- Special handling for embedded resources and generated files to show as nested in Solution Explorer -->
<ItemGroup>
<!-- Update designer files for *.resx files -->
<Compile Update="@(CodeGenerationEmbeddedResource->'%(RecursiveDir)%(Filename).Designer.cs')" DependentUpon="$([System.IO.Path]::ChangeExtension($([System.IO.Path]::GetFileNameWithoutExtension(%(Identity))), '.resx'))" />

<!-- Localized embedded resources are just dependent on the parent RESX -->
<EmbeddedResource Update="**\*.??-??.resx" DependentUpon="$([System.IO.Path]::ChangeExtension($([System.IO.Path]::GetFileNameWithoutExtension(%(Identity))), '.resx'))" />
</ItemGroup>

<ItemGroup>
<None Include="$(MSBuildProjectFileDirectory)$(AssemblyOriginatorKeyFile)" Link="%(Filename)%(Extension)" />
</ItemGroup>
Expand Down
Loading