Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support records in several additional rules #3264

Merged
merged 5 commits into from
Dec 5, 2020

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Dec 5, 2020

  • Add tests for records in many rules
    • SA1106
    • SA1137 (with fixes)
    • SA1201 (with fixes)
    • SA1205 (with fixes)
    • SA1400 (with fixes)
    • SA1500
    • SA1502 (with fixes)
    • SA1505
    • SA1508
    • SA1604
    • SA1605
    • SA1606
    • SA1607
    • SA1608
    • SA1618
    • SA1619
    • SA1625
  • Update SA1205 to support private protected

Fixes #3236

@codecov
Copy link

codecov bot commented Dec 5, 2020

Codecov Report

Merging #3264 (e6720f1) into master (9715fc0) will increase coverage by 0.04%.
The diff coverage is 94.46%.

@@            Coverage Diff             @@
##           master    #3264      +/-   ##
==========================================
+ Coverage   93.48%   93.52%   +0.04%     
==========================================
  Files        1002     1009       +7     
  Lines      109695   109886     +191     
  Branches     3724     3771      +47     
==========================================
+ Hits       102550   102774     +224     
+ Misses       6215     6165      -50     
- Partials      930      947      +17     

@sharwell sharwell merged commit 3414e7a into DotNetAnalyzers:master Dec 5, 2020
@sharwell sharwell deleted the record-order branch December 5, 2020 21:54
@sharwell sharwell added this to the 1.2-beta.next milestone Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SA1201 for records says '<unknown>' should not follow an enum
1 participant