Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default rule set for StyleCop.Analyzerz #2931

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

vweijsters
Copy link
Contributor

Fixes #2924

@sharwell
Copy link
Member

sharwell commented Apr 9, 2019

How do we ensure this remains correct in the future?

@vweijsters
Copy link
Contributor Author

Through careful reviewing. We don't introduce that many new rules, so it shouldn't be too much work.
It may be a good idea to add a review checklist to CONTRIBUTING.md at some point.

@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #2931 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2931   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files         778      778           
  Lines      100144   100144           
  Branches     3265     3265           
=======================================
  Hits        97574    97574           
  Misses       1702     1702           
  Partials      868      868

@sharwell sharwell merged commit ed2f145 into DotNetAnalyzers:master Apr 9, 2019
@sharwell sharwell deleted the fix-2924 branch April 9, 2019 23:11
@sharwell sharwell added this to the 1.2-beta.next milestone Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants