Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore spacing around a default literal expression #2423

Merged
merged 1 commit into from
Jun 17, 2017
Merged

Ignore spacing around a default literal expression #2423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions StyleCop.Analyzers/StyleCop.Analyzers/Lightup/SyntaxKindEx.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ internal static class SyntaxKindEx
{
public const SyntaxKind UnderscoreToken = (SyntaxKind)8491;
public const SyntaxKind IsPatternExpression = (SyntaxKind)8657;
public const SyntaxKind DefaultLiteralExpression = (SyntaxKind)8755;
public const SyntaxKind LocalFunctionStatement = (SyntaxKind)8830;
public const SyntaxKind TupleType = (SyntaxKind)8924;
public const SyntaxKind TupleElement = (SyntaxKind)8925;
Expand Down
10 changes: 10 additions & 0 deletions StyleCop.Analyzers/StyleCop.Analyzers/SpacingRules/SA1000KeywordsMustBeSpacedCorrectly.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ namespace StyleCop.Analyzers.SpacingRules
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using Microsoft.CodeAnalysis.Diagnostics;
using StyleCop.Analyzers.Lightup;

/// <summary>
/// The spacing around a C# keyword is incorrect.
Expand Down Expand Up @@ -124,6 +125,15 @@ private static void HandleSyntaxTree(SyntaxTreeAnalysisContext context)
break;

case SyntaxKind.DefaultKeyword:
if (token.Parent.IsKind(SyntaxKindEx.DefaultLiteralExpression))
{
// Ignore spacing around a default literal expression for now
break;
}

HandleDisallowedSpaceToken(ref context, token);
break;

case SyntaxKind.NameOfKeyword:
case SyntaxKind.SizeOfKeyword:
case SyntaxKind.TypeOfKeyword:
Expand Down