Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA1010 now properly supports index initializers #1622

Merged
merged 2 commits into from
Oct 14, 2015

Conversation

vweijsters
Copy link
Contributor

Fixes #1617

@codecov-io
Copy link

Current coverage is 79.54%

Merging #1622 into master will not affect coverage as of adcf37f

@@            master   #1622   diff @@
======================================
  Files          527     531     +4
  Stmts        31597   31632    +35
  Branches      8865    8872     +7
  Methods                          
======================================
+ Hit          25133   25162    +29
- Partial       5162    5168     +6
  Missed        1302    1302       

Review entire Coverage Diff as of adcf37f

Powered by Codecov. Updated on successful CI builds.

@sharwell
Copy link
Member

In the following code snippet, would the current implementation fail to report a diagnostic for the space in indexes [?

int[] indexes = { 0 };
var dictionary = new Dictionary<int, int> { [indexes [0]] = 0 };

@vweijsters
Copy link
Contributor Author

It would. I'll address that.

@vweijsters
Copy link
Contributor Author

Updated

sharwell added a commit to sharwell/StyleCopAnalyzers that referenced this pull request Oct 14, 2015
@sharwell
Copy link
Member

👍 This is merged and waiting for the AppVeyor build to complete.

@sharwell sharwell added this to the 1.0.0 Beta 14 milestone Oct 14, 2015
@sharwell sharwell self-assigned this Oct 14, 2015
@sharwell sharwell merged commit 77c2d72 into DotNetAnalyzers:master Oct 14, 2015
@vweijsters vweijsters deleted the fix-1617 branch October 14, 2015 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants