Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SA1132 #1559

Merged
merged 6 commits into from
Oct 15, 2015
Merged

Fix SA1132 #1559

merged 6 commits into from
Oct 15, 2015

Conversation

Maxwe11
Copy link
Member

@Maxwe11 Maxwe11 commented Sep 27, 2015

Fixes #1553
Fixes #1554

@sharwell
Copy link
Member

I don't think this is behaving as you expected for the following [invalid] syntax:

int a, = 3;

In this scenario, the VariableDeclaratorSyntax is not missing, but its child identifier token is.

@Maxwe11
Copy link
Member Author

Maxwe11 commented Sep 28, 2015

updated

@sharwell sharwell added this to the 1.0.0 Beta 14 milestone Sep 29, 2015
@codecov-io
Copy link

Current coverage is 78.63%

Merging #1559 into master will increase coverage by +1.32% as of d072a2f

@@            master   #1559   diff @@
======================================
  Files          531     522     -9
  Stmts        32235   31404   -831
  Branches      8833    8841     +8
  Methods          0               
======================================
- Hit          24924   24694   -230
- Partial       5165    5170     +5
+ Missed        2146    1540   -606

Review entire Coverage Diff as of d072a2f

Powered by Codecov. Updated on successful CI builds.

sharwell added a commit that referenced this pull request Oct 15, 2015
@sharwell
Copy link
Member

👍

@sharwell sharwell self-assigned this Oct 15, 2015
@sharwell sharwell merged commit a07e6e3 into DotNetAnalyzers:master Oct 15, 2015
@Maxwe11 Maxwe11 deleted the SA1132 branch October 15, 2015 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants