Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA1107: Dont report if the previous statement is missing its last token #1543

Merged
merged 1 commit into from
Sep 25, 2015

Conversation

pdelvo
Copy link
Member

@pdelvo pdelvo commented Sep 25, 2015

I know this is pedantic, but it was a little bit annoying. When writing a statement that has its last token missing (e.g. a missing semicolon) SA1107 is reported in the following statement. The reason is that roslyn puts the missing semicolon at the start of the next line. So SA1107 is reported because the next statement is on the same line as the missing semicolon. In this code the whole if statement has squiggles. With this change SA1107 is not reported if the last token of the previous statement is missing.

@codecov-io
Copy link

Current coverage is 77.29%

Merging #1543 into master will not affect coverage as of 0080807

@@            master   #1543   diff @@
======================================
  Files          530     530       
  Stmts        32101   32113    +12
  Branches      8781    8783     +2
  Methods          0       0       
======================================
+ Hit          24814   24823     +9
- Partial       5127    5130     +3
  Missed        2160    2160       

Review entire Coverage Diff as of 0080807

Powered by Codecov. Updated on successful CI builds.

@sharwell sharwell added this to the 1.0.0 Beta 13 milestone Sep 25, 2015
@sharwell sharwell self-assigned this Sep 25, 2015
sharwell added a commit that referenced this pull request Sep 25, 2015
SA1107: Dont report if the previous statement is missing its last token
@sharwell sharwell merged commit b977a00 into DotNetAnalyzers:master Sep 25, 2015
@sharwell sharwell added the fixed label Sep 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants