Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA1636 and SA1641 suppressions and update configuration documentation #1414

Merged
merged 3 commits into from
Sep 8, 2015

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Sep 7, 2015

@AArnott
Copy link
Contributor

AArnott commented Sep 8, 2015

:shipit:

@sharwell
Copy link
Member Author

sharwell commented Sep 8, 2015

Disabling SA1633 by default did not work as expected, because it was not getting reported with the severity set to suppressed. The updated implementation simply avoids reporting a warning when the company name and copyright text are set to their default values.

@oatkins
Copy link
Contributor

oatkins commented Sep 8, 2015

👍

sharwell added a commit that referenced this pull request Sep 8, 2015
Disable SA1633 by default and update configuration documentation
@sharwell sharwell merged commit f73dc87 into DotNetAnalyzers:master Sep 8, 2015
@sharwell sharwell deleted the fix-1366 branch September 8, 2015 12:39
@sharwell sharwell changed the title Disable SA1633 by default and update configuration documentation SA1636 and SA1641 suppressions and update configuration documentation Sep 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SA1636, SA1641 place too heavy a burden on a developer
3 participants