Added codefix for SA1404 #1251
Merged
Added codefix for SA1404 #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// <summary> | ||
| /// The placeholder to insert as part of the code fix. | ||
| /// </summary> | ||
| public const string JustificationPlaceholder = "Code reviewed, suppressed."; |
There was a problem hiding this comment.
💭 I would argue that this is not actually a justification.
|
❓ Do we really want to do anything more than handle the case where no justification is provided, and insert an empty string? I lean towards keeping the code fix for adding |
|
I think Microsoft does the same thing in FxCop, it also adds a standard justification but that one is different from this one. Maybe use that one instead? |
|
Fixed issue #1253 |
| @@ -126,6 +126,12 @@ | |||
| <data name="SA1402CodeFix" xml:space="preserve"> | |||
| <value>Move type to new file</value> | |||
| </data> | |||
| <data name="SA1404CodeFixAdd" xml:space="preserve"> | |||
| <value>Add justification</value> | |||
There was a problem hiding this comment.
💡 I would just use one message (this message, and name it SA1404CodeFix)
| CodeAction.Create( | ||
| MaintainabilityResources.SA1404CodeFix, | ||
| token => AddJustificationToAttributeAsync(context.Document, root, attribute), | ||
| nameof(SA1400CodeFixProvider) + "-Add"), diagnostic); |
There was a problem hiding this comment.
💡 SA1404CodeFixProvider (this one says SA1400)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #1110