Reduce the number of memory allocations in SA1404 (CodeAnalysisSuppressionMustHaveJustification) #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssionMustHaveJustification) * Avoid semantic analysis when simple name analysis will work. This step reuses cached information from SA1121 (UseBuiltInTypeAlias). * Avoid calling `GetTypeByMetadataName` for every attribute in the compilation. Instead, this method is called once per compilation and cached.
|
Thats a huge improvement! I just looked at our unit tests for SA1404 and it does not have any test that uses aliases. We probably want some. |
|
Added some tests |
|
👍 |
sharwell
added a commit
that referenced
this pull request
Aug 8, 2015
Reduce the number of memory allocations in SA1404 (CodeAnalysisSuppressionMustHaveJustification)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetTypeByMetadataNamefor every attribute in the compilation. Instead, this method is called once per compilation and cached.When analyzing StyleCopAnalyzers, SA1404 was the most expensive analyzer in terms of both number of memory allocations and total bytes allocated. The following summary shows the improvement:
Edit: Analysis now run with the instrumenting profiler to verify accuracy.