SA1642 (summary text) misleading for private constructors

[sharwell]

Currently the following constructor results in SA1642:

/// <summary>
/// Initializes a new instance of the <see cref="ApiStatus"/> class with the specified name.
/// </summary>
private ApiStatus(string name)
    : base(name)
{
}

The expected text is the following:

Prevents a default instance of the <see cref="ApiStatus"/> class from being created.

The currently expected text is simply not correct in this case.

Proposal

1. SA1642 should allow either the "non-private" or "private" forms for private constructors.
2. When generating text for a private constructor, the current "non-private" form should be used as the template for this text. Users who are writing new APIs and truly wish to prevent an instance of the type from being created can do so by making static class. We can safely assume that users writing private instance constructors are actually just controlling the manner in which instances are created.

[sharwell]

I initially assigned @pdelvo since he did a great job with the initial implementation. I'll take a look soon if you don't have time.

[sharwell]

I decided to take a look at this one 👟