Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SA1015 and SA1023 conflict with generics #3302

Closed
tertle opened this issue Feb 16, 2021 · 0 comments · Fixed by #3309
Closed

SA1015 and SA1023 conflict with generics #3302

tertle opened this issue Feb 16, 2021 · 0 comments · Fixed by #3309
Assignees
@sharwell
Labels
bug c# 8 fixed
Milestone
1.2.0-beta.333

Comments

@tertle
Copy link

tertle commented Feb 16, 2021 •
edited
Loading

Since c#8 unmanaged constructed types have been allowed, but this causes a conflict between SA1015 and SA1023 where

internal UnsafeList<int>* Tris;

Triggers https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1015.md
As there is no spacing after the generic brackets, but adding spaces

internal UnsafeList<int> *Tris;

Triggers https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1023.md
As spaces aren't allowed before dereference or access-of symbol and one must exist after.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
bug c# 8 fixed
Projects
None yet
Milestone
1.2.0-beta.333
Development

Successfully merging a pull request may close this issue.

Fix handling of pointers to generic types sharwell/StyleCopAnalyzers
2 participants
@sharwell @tertle