Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA1627: MessageFormat contains \' #2918

Closed
RalfKoban opened this issue Mar 24, 2019 · 1 comment
Closed

SA1627: MessageFormat contains \' #2918

RalfKoban opened this issue Mar 24, 2019 · 1 comment
Labels
Milestone

Comments

@RalfKoban
Copy link
Contributor

The rule 'SA1627' reports a violation if an XML element is empty.

The documentation resource SA1627MessageFormat for the rule wraps the XML element inside \'.
So a violation would be reported as The documentation text within the \'remarks\' tag should not be empty.

It would be better if the documentation resource text would use ' instead of \', so that the violation would be reported as The documentation text within the 'remarks' tag should not be empty.

sharwell added a commit that referenced this issue Mar 24, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fix for #2918 - Update 'SA1627MessageFormat' in 'DocumentationResources.resx'
@sharwell
Copy link
Member

Fixed by #2919

@sharwell sharwell added the fixed label Mar 24, 2019
@sharwell sharwell added this to the 1.2-beta.next milestone Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants