SA1000 ignores 'default' in a default literal expression

[sharwell]

Currently SA1000 is getting reported for the following C# 7.1 syntax:

var x = value == null ? default : 3;

Edit: a workaround is now implemented to simply ignore default literal expressions. The bug has a new title for providing full support for this keyword.

[tillig]

Under .NET Core 3.1 and StyleCopAnalyzers 1.1.118 this appears to have been resolved (probably due to the submitted PR) and can be closed.

[sharwell]

It's still open to review cases where diagnostics should be reported. Right now diagnostics are not reported even for unexpected spacing, such as when the spaces around default are removed.

[jethas-bennettjones]

I'm using .NET 5 and v1.1.118 of the analyzer, and I'm seeing it.

[sharwell]

@jethas-bennettjones you're seeing #3214

[bjornhellander]

I think the current behaviour is correct. In this context, default is equivalent to a literal or a variable, so I expect SA1000 to continue to ignore it. Removing the trailing space in this example already triggers SA1003 and SA1024.

SA1000 tests should be added, though, to make sure that it doesn't regress.