Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SA1028 code fix throws ArgumentOutOfRangeException #1313

Closed
pdelvo opened this issue Aug 28, 2015 · 3 comments
Closed

SA1028 code fix throws ArgumentOutOfRangeException #1313

pdelvo opened this issue Aug 28, 2015 · 3 comments
Assignees
@pdelvo
Labels
bug fixed
Milestone
1.0.0 Beta 9

Comments

@pdelvo
Copy link
Member

pdelvo commented Aug 28, 2015

Im currently implementing #1199 and while testing I discovered that this line throws an ArgumentOutOfRangeException when trying to auto fix SA1028 on the roslyn codebase
@sharwell sharwell added this to the 1.0.0 Beta 9 milestone Aug 28, 2015
@Noryoko
Copy link
Contributor

Noryoko commented Aug 28, 2015

Grabbing.

@pdelvo
Copy link
Member Author

pdelvo commented Aug 28, 2015

I just noticed I wrote NRE. It was actually an ArgumentOutOfRangeException.

@Noryoko
Copy link
Contributor

Noryoko commented Aug 28, 2015

Was about to ask. Thanks for clarifying.

pdelvo added a commit to pdelvo/StyleCopAnalyzers that referenced this issue Aug 29, 2015
@pdelvo
Add regression test for DotNetAnalyzers#1313
8c6f3ea
@pdelvo pdelvo mentioned this issue Aug 29, 2015
Merged
@sharwell sharwell assigned pdelvo and unassigned Noryoko Aug 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pdelvo pdelvo

Labels
bug fixed
Projects
None yet
Milestone
1.0.0 Beta 9
Development

No branches or pull requests
3 participants
@sharwell @pdelvo @Noryoko