Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable SA1412 by default until we can work out the usability problems #1240

Closed
sharwell opened this issue Aug 18, 2015 · 2 comments · Fixed by #1264
Closed

Disable SA1412 by default until we can work out the usability problems #1240

sharwell opened this issue Aug 18, 2015 · 2 comments · Fixed by #1264
Assignees
Milestone

Comments

@sharwell
Copy link
Member

SA1412 "works", but it currently has several usability problems that people need to be aware of before applying it to their projects. We should set the diagnostic as DisabledByDefault until we figure out how to address the other issues.

Current issues related to this:

@Noryoko
Copy link
Contributor

Noryoko commented Aug 21, 2015

Grabbing.

@julealgon
Copy link

@sharwell , I found this issue because I intended to ask a question regarding why this specific analyzer rule was turned off by default. While I'm glad I found it and thus won't need to create my question issue, I'd propose that the reason why the rule has been disabled by default be made explicit in the documentation page for the rule, or at least in the dotnetanalyzers.github.io page.

All it says there today is this:

📝 This rule is new for StyleCop Analyzers, and was not present in StyleCop Classic.

I believe exposing the reason as to why it is disabled by default would help other folks looking for the information like I was.

This of course goes for any other "disabled-by-default" rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants