Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA1412 code fix does not work properly on linked files #1168

Open
sharwell opened this issue Aug 9, 2015 · 2 comments
Open

SA1412 code fix does not work properly on linked files #1168

sharwell opened this issue Aug 9, 2015 · 2 comments

Comments

@sharwell
Copy link
Member

sharwell commented Aug 9, 2015

When the SA1412 code fix is applied to a fix that is included in the project via a link, a copy of the original file is made at the target location of the link, and the new copy is included in the project instead of the original file.

💭 It might be possible to trick this into working by using a normal code fix that inserts a blank line at the beginning of the document. This would trigger a violation of a different rule, but then by fixing all instances of that rule you'd have a working encoding change that doesn't require changes to the project system.

@pdelvo
Copy link
Member

pdelvo commented Aug 9, 2015

I dont think this would work. I tried to make a text change to the document so that the encoding change is not the only change. but the encoding change was not working.

@sharwell
Copy link
Member Author

Blocked on dotnet/roslyn#4767

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants