Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure error is raised from _ensure_user when the user doesn't exist #628

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

SamHames
Copy link
Contributor

@SamHames SamHames commented Apr 20, 2022

Refactors _ensure_user to not rely on ensure_flattened, and handle
the response directly, as we know exactly what to expect here.

This closes #626 , by ensuring that an appropriate error message
indicating that the user doesn't exist is raised.

Refactors _ensure_user to not rely on ensure_flattened, and handle
the response directly, as we know exactly what to expect here.
@SamHames SamHames requested a review from igorbrigadir April 20, 2022 03:31
@igorbrigadir igorbrigadir merged commit 68210a8 into main Apr 20, 2022
@igorbrigadir
Copy link
Contributor

Thanks! Yes, this makes more sense to do it this way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeline CLI command should not assume that the user exists
2 participants