fix(cli): addr parameter of dx serve #3351
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I run
dx serve --addr 0.0.0.0in order to receive requests from any ip address, then currently the dev server tries to forward this request to 0.0.0.0, however since the proxied server is always started on the same machine, I believe that the request should always be forwarded to localhost.Is that correct, or am I misunderstanding how the addr parameter should work?
I was also considering changing the address to localhost in the proxied_server_address function as well, so that also the proxied server would always only listen to localhost, but then I thought it might be useful to be able to reach it directly as well, when specifying the address as 0.0.0.0 and calling from another host.