Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add web3 profile feed #6896

Merged
merged 204 commits into from
Aug 1, 2022
Merged

feat: add web3 profile feed #6896

merged 204 commits into from
Aug 1, 2022

Conversation

Randolph314
Copy link
Contributor

@Randolph314 Randolph314 commented Jul 27, 2022

Description

Closes #792

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

guanbinrui and others added 30 commits July 8, 2022 16:10
* feat: delete LinkOutIcon initial fill color

* feat: refresh wallet setting date when wallets change

* feat: change button name and collection style

Co-authored-by: Randolph <[email protected]>
* fix: detecting scenechange

* fix: follow up reviews

* add useSceneChange hook
@github-actions github-actions bot temporarily deployed to pull request August 1, 2022 03:41 Inactive
<Typography fontSize="16px" fontWeight={700} marginTop="16px">
{t.description()}
</Typography>
<div style={{ display: '-webkit-box' }} className={classes.threeLine}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use display: flex.

{t.contributions()}
</Typography>
<Typography fontSize="16px" fontWeight={700} marginBottom="16px">
{1}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a dead number here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to API, it always 1

@github-actions github-actions bot temporarily deployed to pull request August 1, 2022 06:17 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2022 07:08 Inactive
@guanbinrui guanbinrui merged commit 8d5ac12 into develop Aug 1, 2022
@guanbinrui guanbinrui deleted the feat/web3-profile-feed branch August 1, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants