Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle chart text over canvas #6815

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Conversation

Lanttcat
Copy link
Contributor

Description

Closes # (NO_ISSUE)

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2022

@github-actions github-actions bot temporarily deployed to pull request July 19, 2022 02:19 Inactive
Jack-Works
Jack-Works previously approved these changes Jul 19, 2022
@Lanttcat Lanttcat force-pushed the fix/trending-chart branch from ffcb846 to 1032139 Compare July 28, 2022 01:25
@github-actions github-actions bot temporarily deployed to pull request July 28, 2022 01:31 Inactive
@Lanttcat Lanttcat force-pushed the fix/trending-chart branch from 1032139 to 1fe17a7 Compare July 28, 2022 01:39
@github-actions github-actions bot temporarily deployed to pull request July 28, 2022 01:46 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants