Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mempool_tests.cpp Unit Test #195

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Conversation

JaredTate
Copy link

@JaredTate JaredTate commented Mar 14, 2024

This PR begins work to fix the Unit tests. Unit tests are the most important C++ tests located in the src folder and are what first runs when you make check. This fixes mempool_tests.cpp & miner_tests.cpp. I don't know how many of these are failing but will take them one by one.

You can read more about Unit Tests here:
https://github.com/DigiByte-Core/digibyte/blob/develop/src/test/README.md

To Compile & Run Unit Tests:

  ./autogen.sh
  ./configure
  make -j 8
  make check

Run Specific Unit Test Fixed

cd src/test
./test_digibyte --run_test=mempool_tests --log_level=message
./test_digibyte --run_test=miner_tests --log_level=message

You can also re-run make check but it will just take longer for a specific test.

Screenshot 2024-03-14 at 2 18 42 PM

It is important to note while trying to fix these Unit tests you need to make every time you make a change to recompile & re-run test.

I am using --log_level=message and BOOST_TEST_MESSAGE to help me trouble shoot these unit tests with log outputs.

@ycagel ycagel requested review from SmartArray, ycagel, digicontributer, gto90, j50ng and a user March 14, 2024 20:22
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK Tested nice work @JaredTate

Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Member

@ycagel ycagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK. Great work @JaredTate!

@ycagel ycagel merged commit b9e9c4f into DigiByte-Core:develop Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants