Refactor temp dir logic

[noamokman]

Hi there!

Just replaced the temp dir logic with a module.
Better support for windows.

Thanks 😄

[noamokman]

Ping 🔔
Is there a problem with the PR?

[Dexus]

Yes, i don't like to use more deps as needed. And the module is not needed.

Am 17.11.2015 um 05:40 schrieb Noam Okman [email protected]:

Ping
Is there a problem with the PR?

—
Reply to this email directly or view it on GitHub.

[noamokman]

Hi @Dexus,
First of all, If you would look at the code you would see that this package covers windows cases that your line does not.
That is the main functional reason for this PR

The module is a polyfill for the os.tempDir function and it is helps you get a consistent behavior on different Node.js versions (even 0.8).

Also, in general, using small modules help make your code less complex, so you wouldn't have to know how to get the temp dir in your code.
you can simply get it from someone else who has done the job for you.
That is the beauty in Node.js and the npm ecosystem.

I highly suggest that you read this thread: sindresorhus/ama#10
It talks about single line modules and why it is important.

I just think it would help, and make the code a bit cleaner.
If you are still unconvinced,
The necessary changes to make this work for windows too is something like this:

var isWindows = process.platform === 'win32';
var trailingSlashRe = isWindows ? /[^:]\\$/ : /.\/$/;
var path = (os.tmpdir || os.tmpDir) && (os.tmpdir || os.tmpDir)();

if (isWindows) {
    path = path || 
        (process.env.SystemRoot || process.env.windir) + '\\temp';
} else {
    path =  path || 
        '/tmp';
}

if (trailingSlashRe.test(path)) {
    path = path.slice(0, -1);
}

Based on the original module.

I hope you reconsider. 😄