Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added jobTitle to Person #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kanedafromparis
Copy link

Hi!

I tried to add job title to personnes because I needed it, and it might be useful.

Its a first test, please all feedback are welcom

@mariuszs
Copy link
Member

Thanks, but I'm not sure about adding field job related field directly to Person. Maybe we should add something like Employee to Company with more data like department, profession etc.

@kanedafromparis
Copy link
Author

That's a good point.
I added it to personne because :

  • it was the simplest
  • it feel to be a field like "contact" where "Job Title" and Company are linked to your name.
    like : https://en.wikipedia.org/wiki/VCard
    but then Title might be better then jobTitle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants