Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some file types to open file dialogs. #521

Merged
merged 1 commit into from
May 14, 2022
Merged

Added some file types to open file dialogs. #521

merged 1 commit into from
May 14, 2022

Conversation

veler
Copy link
Collaborator

@veler veler commented May 14, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Users can open any kind of file in the CustomTextBox and CodeEditor control. It is unclear to the user that only textual files can be opened.

What is the new behavior?

Tried to make it clearer to the user that only textual files can be opened.

Other information

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@veler veler added the enhancement Idea of improvement of existing feature. label May 14, 2022
@veler veler merged commit 4690b53 into main May 14, 2022
@veler veler deleted the filetypes branch May 14, 2022 15:57
@veler veler added this to the v1.0.7.0 milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Idea of improvement of existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant