Feature/add refresh button lorem ipsum #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenisMtfl
approved these changes
Feb 21, 2022
veler
requested changes
Mar 1, 2022
There was a problem hiding this comment.
Hello,
Thank you very much for this contribution, and I'm sorry for the delay to look at it. I had a lot of work these past weeks.
Overall, it looks pretty nice. I'd just highly recommend to use a Command instead of an Event in the CustomTextBox for handling the Refresh button. :)
Thank you again!
...dev/impl/DevToys/Views/Tools/Generators/LoremIpsumGenerator/LoremIpsumGeneratorToolPage.xaml
Outdated
Show resolved
Hide resolved
|
Hi @veler, I fixed the code with your recommendations. Can you have a look and let know if it is OK? Thanks and have a nice day. |
Hello :) It looks great! :D Thank you for applying the changes! Let's just address the merge conflict, and we can merge 🗡️ |
veler
approved these changes
Mar 3, 2022
|
Hello @Guzzter :) If you address the merge conflict, we can merge this PR ;-) |
|
Awesome! Thank you very much :D |
Closed
veler
added a commit
that referenced
this pull request
Mar 26, 2022
* Number conversion using custom bases functionalities and few tests * Functionalities to format numbers using any base and dictionary * Add new language text * Change models to fit new features * Add new communication messages between number converter view models * Add views and functionalities to allow custom dictionaries * Activate model to receive messages * Include language generated component * Rebase and cleanup code * Update InfoBar message to show/hide it correctly * Remove remaining code generating compile errors * Code refactoring * Fix test cases * Added the possibility to Favorite/Unfavorite a tool. (#437) * Added the possibility to Favorite/Unfavorite a tool. * Updated localization * addressed feedback * Fix README.md minor typo (#441) * Update japanese translation. (#444) * Bumped up version number * Feature/add refresh button lorem ipsum (#413) * Add StartWithLoremIpsum option * Updated language bundles * Added refresh buttom for lorem ipsum * Replaced click handler with Refresh ICommand * Fixing error Co-authored-by: Guus Beltman <[email protected]> * Added some assets * Updated chocolatey * updated wikiUrl in Chocolatey * Update Traditional Chinese translation (#442) * Updates to cs-CZ localization (#447) * feature: 💬 add new lang (Portuguese-Brazil) (#449) * Update japanese translation. (lorem ipsum) (#450) * Update japanese translation. (lorem ipsum) * Fix typo. * Update chinese translation (#451) * Added String Escape / Unescape tool (#446) * Set nullable * Set nullable and change to string dictionaries * Fix errors, inject view models and improve code * Add translations * Number conversion using custom bases functionalities and few tests * Functionalities to format numbers using any base and dictionary * Add new language text * Change models to fit new features * Add new communication messages between number converter view models * Add views and functionalities to allow custom dictionaries * Activate model to receive messages * Include language generated component * Rebase and cleanup code * Update InfoBar message to show/hide it correctly * Remove remaining code generating compile errors * Code refactoring * Fix test cases * Set nullable * Set nullable and change to string dictionaries * Fix errors, inject view models and improve code * Add translations * Automatic input when navigating to the tool Co-authored-by: Etienne BAUDOUX <[email protected]> Co-authored-by: kspc1000 <[email protected]> Co-authored-by: Sou Niyari <[email protected]> Co-authored-by: Guus Beltman <[email protected]> Co-authored-by: Guus Beltman <[email protected]> Co-authored-by: SiderealArt <[email protected]> Co-authored-by: Morning4coffe <[email protected]> Co-authored-by: Rafael Andrade de Oliveira <[email protected]> Co-authored-by: Boring3 <[email protected]>
veler
pushed a commit
that referenced
this pull request
Mar 31, 2023
* Add StartWithLoremIpsum option * Updated language bundles * Added refresh buttom for lorem ipsum * Replaced click handler with Refresh ICommand * Fixing error Co-authored-by: Guus Beltman <[email protected]>
veler
added a commit
that referenced
this pull request
Mar 31, 2023
* Number conversion using custom bases functionalities and few tests * Functionalities to format numbers using any base and dictionary * Add new language text * Change models to fit new features * Add new communication messages between number converter view models * Add views and functionalities to allow custom dictionaries * Activate model to receive messages * Include language generated component * Rebase and cleanup code * Update InfoBar message to show/hide it correctly * Remove remaining code generating compile errors * Code refactoring * Fix test cases * Added the possibility to Favorite/Unfavorite a tool. (#437) * Added the possibility to Favorite/Unfavorite a tool. * Updated localization * addressed feedback * Fix README.md minor typo (#441) * Update japanese translation. (#444) * Bumped up version number * Feature/add refresh button lorem ipsum (#413) * Add StartWithLoremIpsum option * Updated language bundles * Added refresh buttom for lorem ipsum * Replaced click handler with Refresh ICommand * Fixing error Co-authored-by: Guus Beltman <[email protected]> * Added some assets * Updated chocolatey * updated wikiUrl in Chocolatey * Update Traditional Chinese translation (#442) * Updates to cs-CZ localization (#447) * feature: 💬 add new lang (Portuguese-Brazil) (#449) * Update japanese translation. (lorem ipsum) (#450) * Update japanese translation. (lorem ipsum) * Fix typo. * Update chinese translation (#451) * Added String Escape / Unescape tool (#446) * Set nullable * Set nullable and change to string dictionaries * Fix errors, inject view models and improve code * Add translations * Number conversion using custom bases functionalities and few tests * Functionalities to format numbers using any base and dictionary * Add new language text * Change models to fit new features * Add new communication messages between number converter view models * Add views and functionalities to allow custom dictionaries * Activate model to receive messages * Include language generated component * Rebase and cleanup code * Update InfoBar message to show/hide it correctly * Remove remaining code generating compile errors * Code refactoring * Fix test cases * Set nullable * Set nullable and change to string dictionaries * Fix errors, inject view models and improve code * Add translations * Automatic input when navigating to the tool Co-authored-by: Etienne BAUDOUX <[email protected]> Co-authored-by: kspc1000 <[email protected]> Co-authored-by: Sou Niyari <[email protected]> Co-authored-by: Guus Beltman <[email protected]> Co-authored-by: Guus Beltman <[email protected]> Co-authored-by: SiderealArt <[email protected]> Co-authored-by: Morning4coffe <[email protected]> Co-authored-by: Rafael Andrade de Oliveira <[email protected]> Co-authored-by: Boring3 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Added refresh button to CustomTextBox to enable support for regenerate the action (in this case Lorem Ipsum)
Please check the type of change your PR introduces:
What is the current behavior?
To get new Lorem Ipsum text you need to change settings.
Issue Number: #361
What is the new behavior?
Not with the Refresh button you can get new text with single click.
Other information
Quality check
Before creating this PR, have you: