Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonHelper.IsValid is not matching some JSON structures #363

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

a-khanna
Copy link
Contributor

@a-khanna a-khanna commented Feb 9, 2022

This PR corrects JsonHelper.IsValid and JsonHelper.Format to support some valid Json inputs like "foo", 123, and null

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Issue Number: #243

What is the new behavior?

JsonHelper.IsValid now returns true for Json inputs like "foo", 123, and null

Other information

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@veler veler linked an issue Feb 10, 2022 that may be closed by this pull request
@veler veler added this to the v1.0.3.0 milestone Feb 11, 2022
@veler
Copy link
Collaborator

veler commented Feb 11, 2022

Hello, thank you for proposing this fix, and sorry for not taking action on this issue before!
The PR looks all good to me. I will merge it. :)
Have a great day !

@veler veler merged commit 7dc54da into DevToys-app:main Feb 11, 2022
@a-khanna a-khanna deleted the bug/bug-243 branch February 12, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JsonHelper.IsValid is not matching some JSON structures
2 participants