Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/button align #324

Merged
merged 2 commits into from
Feb 2, 2022
Merged

Bug/button align #324

merged 2 commits into from
Feb 2, 2022

Conversation

btiteux
Copy link
Collaborator

@btiteux btiteux commented Feb 1, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Some button are not properly align.
image

Issue Number & close #246

What is the new behavior?

The button are now align.
image

Other information

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@btiteux btiteux added the bug Something isn't working label Feb 1, 2022
Copy link
Collaborator

@veler veler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@veler veler merged commit 6dbd7b4 into main Feb 2, 2022
@veler veler deleted the bug/button-align branch February 2, 2022 00:35
veler pushed a commit that referenced this pull request Mar 31, 2023
* added MarkupExtension to align button on some toys

* definitive bug fixes for button align
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad control alignment in Output text box
2 participants