Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port : Add REST endpoints to tag and untag policies in bulk #830

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

sahibamittal
Copy link
Collaborator

@sahibamittal sahibamittal commented Aug 7, 2024

Description

Adds the new endpoints:

POST /api/v1/tag/{name}/policy
DELETE /api/v1/tag/{name}/policy

And deprecates the redundant endpoints:

POST /api/v1/policy/{uuid}/tag/{name}
DELETE /api/v1/policy/{uuid}/tag/{name}

Addressed Issue

Backport change : DependencyTrack/hyades#1358

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@sahibamittal sahibamittal added enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base labels Aug 7, 2024
@sahibamittal sahibamittal added this to the 5.6.0 milestone Aug 7, 2024
Copy link
Collaborator

@mehab mehab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.03% (target: -1.00%) 92.86% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f060f75) 21021 17284 82.22%
Head commit (43efc03) 21077 (+56) 17336 (+52) 82.25% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#830) 56 52 92.86%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@sahibamittal sahibamittal merged commit f98b6b2 into main Aug 7, 2024
9 checks passed
@sahibamittal sahibamittal deleted the port-tag-untag-policies branch August 7, 2024 14:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants