Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support inclusion/exclusion of projects from BOM validation with tags #4109

Merged
merged 2 commits into from
Sep 1, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Sep 1, 2024

Description

Supports the inclusion or exclusion of projects from BOM validation, using tags.

  • Removes the artifact:bom.validation.enabled config property
  • Adds the new artifact:bom.validation.mode config property
    • Valid options are ENABLED, DISABLED, ENABLED_FOR_TAGS, DISABLED_FOR_TAGS
    • Existing artifact:bom.validation.enabled configs are migrated to their artifact:bom.validation.mode counterpart
  • Adds the new artifact:bom.validation.tags.exclusive and artifact:bom.validation.tags.inclusive config properties to support the new ENABLED_FOR_TAGS and DISABLED_FOR_TAGS modes

Addressed Issue

Closes #3891

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro nscuro added the enhancement New feature or request label Sep 1, 2024
@nscuro nscuro added this to the 4.12 milestone Sep 1, 2024
@nscuro nscuro marked this pull request as ready for review September 1, 2024 15:54
Copy link

codacy-production bot commented Sep 1, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+1.52% (target: -1.00%) 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (bd17623) 22419 17229 76.85%
Head commit (ea1bf33) 22080 (-339) 17304 (+75) 78.37% (+1.52%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4109) 68 68 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro merged commit 2057e62 into DependencyTrack:master Sep 1, 2024
11 checks passed
@nscuro nscuro deleted the issue-3891 branch September 1, 2024 17:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include or Exclude Projects From BOM Validation Using Tags
1 participant