Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Jakarta EE 10 and Jetty 12 #3730

Merged
merged 2 commits into from
May 28, 2024
Merged

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented May 17, 2024

Description

Performs the migration from Java EE to Jakarta EE 10 (see here for background).

This migration is crucial to prevent the Dependency-Track code base from falling behind, and accumulating too much tech debt. Major frameworks like Spring and Quarkus migrated to Jakarta EE years ago.

This also upgrades the embedded Jetty from 10 to 12. 12 being the latest, and only community-supported version of Jetty:

Jetty 12 is the only community supported versions of Jetty at this point in time, and has a great many improvements over previous releases.

While many people continue to use older versions of Jetty like 11/10/9 for a variety of reasons, we recommend using Jetty 12

Note that Jetty 12 is the only version that will receive support for the open source community, and represents the version of Jetty that we will actively maintain and improve over the next few years.

January 1st, 2024 marks the end of community support for the Jetty 11 and older releases.

(Source)

Addressed Issue

Closes #2727

Additional Details

Depends on stevespringett/Alpine#570

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro nscuro marked this pull request as draft May 17, 2024 20:51
@nscuro nscuro added this to the 4.12 milestone May 20, 2024
@nscuro nscuro force-pushed the jakarta-ee branch 2 times, most recently from a8f0f83 to 7a7d33b Compare May 20, 2024 15:31
@nscuro nscuro marked this pull request as ready for review May 28, 2024 08:54
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.03% (target: -1.00%) 50.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9ac6995) 21640 16399 75.78%
Head commit (0351858) 21667 (+27) 16425 (+26) 75.81% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3730) 4 2 50.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@nscuro nscuro merged commit 1f2cc28 into DependencyTrack:master May 28, 2024
10 of 12 checks passed
@nscuro nscuro deleted the jakarta-ee branch May 28, 2024 09:08
@nscuro nscuro mentioned this pull request May 29, 2024
2 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade to Jetty 11 Maven plugin
1 participant