Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter years before account creation #449

Merged
merged 3 commits into from
Feb 7, 2023

Conversation

DenverCoder1
Copy link
Owner

@DenverCoder1 DenverCoder1 commented Feb 7, 2023

Description

Filter out years with contributions that are before the user's account creation.

This limits the number of requests for users with backdated commits such as commits on Jan 1, 1970.

Fixes #448

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

@DenverCoder1 DenverCoder1 added the bug Something isn't working label Feb 7, 2023
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-filter-yea-hd5j9x February 7, 2023 17:52 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-filter-yea-yad2ir February 7, 2023 18:02 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-filter-yea-hd5j9x February 7, 2023 18:02 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-filter-yea-ujwih0 February 7, 2023 19:11 Inactive
@DenverCoder1 DenverCoder1 merged commit fc1ce8e into main Feb 7, 2023
@DenverCoder1 DenverCoder1 deleted the filter-years-before-account-creation branch February 7, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not sure if bug or misunderstanding of how to use.
1 participant