Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some deprecated calls #1432

Merged
merged 3 commits into from
Nov 5, 2018

Conversation

chris48s
Copy link
Member

@chris48s chris48s commented Oct 23, 2018

This fixes the following deprecation warnings:

  • RemovedInDjango20Warning: Importing from django.core.urlresolvers is deprecated in favor of django.urls.
  • RemovedInDjango20Warning: Specifying a namespace in django.conf.urls.include() without providing an app_name is deprecated. Set the app_name attribute in the included module, or pass a 2-tuple containing the list of patterns and app_name instead.

RemovedInDjango20Warning: Importing from
django.core.urlresolvers
is deprecated in favor of django.urls.
@ghost ghost assigned chris48s Oct 23, 2018
@ghost ghost added the Review label Oct 23, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 70.957% when pulling 3d86650 on chris48s:deprecation-fixes into 05217cc on DemocracyClub:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 70.957% when pulling 3d86650 on chris48s:deprecation-fixes into 05217cc on DemocracyClub:master.

@chris48s
Copy link
Member Author

Got a bit enthusiastic trying to remove some stuff that's deprecated in DRF 1.9 before we've actually applied that upgrade. I've made some notes in #1428 (comment)

Thanks, Continuous Integration :)

@chris48s chris48s merged commit 2b5e4bf into DemocracyClub:master Nov 5, 2018
@ghost ghost removed the Review label Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants