Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty printer #14

Open
gabrielhdt opened this issue Oct 17, 2019 · 5 comments
Open

Pretty printer #14

gabrielhdt opened this issue Oct 17, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@gabrielhdt
Copy link
Member

Could the binary of the pretty printer be passed as an argument of logigen? For instance, one would use logigen -i json/ -o web --pp /usr/bin/ppt. By default, the json object could be printed (although it's not pretty).

@gabrielhdt gabrielhdt added the enhancement New feature or request label Oct 17, 2019
@rprimet
Copy link
Contributor

rprimet commented Oct 17, 2019

Yep the pretty-printer could be an option, especially if we have 2+ choices, but I'd rather have a good default (otherwise the CLI might become tedious to use).

@gabrielhdt
Copy link
Member Author

So you want the pretty printer to be in the repository?

@rprimet
Copy link
Contributor

rprimet commented Oct 17, 2019 via email

@rprimet
Copy link
Contributor

rprimet commented Oct 17, 2019

Come to think of it, being able to set the pretty-printer executable through an environment variable (e.g LOGIPEDIA_PP or similar) might also be a good choice (but then we need to define a priority order...)

@gabrielhdt
Copy link
Member Author

Ah all right, that's a good idea. I think we should

  1. use an environment variable
  2. use the command line flag

so that if both are set, the command line flag is taken into account. Why not logipedia-pp or logipp, take the one you prefer. I have already some prototypes at logippedia.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants