Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #319 #323

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Fix #319 #323

merged 2 commits into from
Jun 14, 2024

Conversation

GuillaumeGen
Copy link
Contributor

No description provided.

@fblanqui
Copy link
Member

fblanqui commented Mar 1, 2024

Is it fixing #295 too?

@GuillaumeGen
Copy link
Contributor Author

Clearly not, but I can fix it too. Commit tonight.

@GuillaumeGen
Copy link
Contributor Author

Done in #325 . Since this change is a (very little) bit more questionable than the ones for #318 and #319, I opened a separate PR to discuss it. Once it has been decided (let's hope very soon), I can group those three small changes in one pull request.

gabrielhdt
gabrielhdt previously approved these changes Apr 7, 2024
View reviewed changes
@gabrielhdt gabrielhdt merged commit 3dbbffd into Deducteam:master Jun 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielhdt gabrielhdt gabrielhdt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuillaumeGen @fblanqui @gabrielhdt