Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support for Coq 8.10' SProp #9

Open
rafoo opened this issue May 15, 2020 · 11 comments
Open

Feature Request: Support for Coq 8.10' SProp #9

rafoo opened this issue May 15, 2020 · 11 comments

Comments

@rafoo
Copy link
Contributor

rafoo commented May 15, 2020

Currently, Coqine's opam file requires a fixed version of Coq (8.8.2). The current stable version of Coq is 8.11.1. Are there plans to update the dependency?

@francoisthire
Copy link
Contributor

One issue is probably the version 8.10 which introduces sprop. Maybe it is easy to fix, but clearly it will change the encoding. Moreover, one should investigate the sprop property that if A : sprop and a a' : A then a is convertible to a'.

@rafoo
Copy link
Contributor Author

rafoo commented May 24, 2020

I thought the encoding was already designed as part of your Types 2019 paper "Proof Irrelevance and Predicate Subtyping in Dedukti".

@francoisthire
Copy link
Contributor

I thought the encoding was already designed as part of your Types 2019 paper "Proof Irrelevance and Predicate Subtyping in Dedukti".

It was not implemented because at that time Coq 8.10 was not released.

@rafoo
Copy link
Contributor Author

rafoo commented May 25, 2020

Ok, it makes sense.

@rafoo rafoo changed the title Upgrade to a more recent version of Coq Feature Request: Support for Coq 8.10' SProp May 25, 2020
@amelieled
Copy link

Hi! :)
So, if I understand correctly, it's better for now to use Coq 8.8.0 with CoqIne, all right?

@amelieled
Copy link

It's very sad because @Gaspi has done a good job, and currently, there are only 6 errors/warnings:

File "src/modules.mli", line 13, characters 73-99:
Error: The type constructor Declarations.constant_body expects 1 argument(s),
       but is here applied to 0 argument(s)

File "src/error.ml", line 6, characters 9-29:
Error: Unbound value CErrors.make_anomaly

File "src/inductives.ml", line 98, characters 66-87:
Error: This expression has type template_arity
       The field template_param_levels does not belong to type Declarations.template_arity

File "src/cname.ml", line 26, characters 61-90:
Error (warning 3): deprecated: VarRef
Use Names.GlobRef.VarRef

File "src/tsorts.ml", line 80, characters 12-29:
Error: Unbound value Term.kind_of_type

File "src/terms.ml", line 68, characters 8-25:
Error: Unbound value Term.kind_of_type1

Good luck! :)

@francoisthire
Copy link
Contributor

francoisthire commented Nov 9, 2020 via email

@Gaspi
Copy link
Collaborator

Gaspi commented Nov 10, 2020

I thought the encoding was already designed as part of your Types 2019 paper "Proof Irrelevance and Predicate Subtyping in Dedukti".

Sadly, no. The results of this paper are only used to have the irrelevance of annotating sorts inside the encoding for now. It seems doable to extend it to sprop.

@amelieled
Copy link

A good task for a new commer I guess. More seriously, probably someone
should take over the burden of maintenance of CoqInE.

Je veux bien aider @Gaspi pour reprendre la main sur la maintenance par la suite.
C'est potentiellement ambitieux, mais il faut bien commencer quelque part :)

@Gaspi
Copy link
Collaborator

Gaspi commented Nov 14, 2020

C'est très courageux de ta part :) Je suis sur que tu seras à la hauteur !
Une première étape serait de réussir à faire fonctionner l'outil chez toi sur la version de Coq pour laquelle il a été conçu (8.8.2 semble-t-il).
Ensuite je te conseille de "remonter" les versions progressivement. A chaque montée de version la compilation va casser en générant plein (ça peut être des centaines) d'erreurs/warning dus aux petites (ou grandes) variations dans le kernel de Coq : types inductifs légèrement différents, fonctions qui deviennent deprecated ou disparaissent, etc.
Le gros du boulot c'est de comprendre et réparer ces petites erreurs. Parfois ça nécessite de bien comprendre la théorie de Coq.
Bon courage et si tu es complètement bloquée n'hésite pas partager le bug, ça pourra peut-être m'évoquer quelque chose.

@rafoo
Copy link
Contributor Author

rafoo commented Nov 15, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants