Add articles to R Programming page #130
Conversation
pull latest updates from main repository
|
@lgreski I don't believe there is a capstone page. |
|
Would you mind taking the link out until the link is live? (Or I can just wait until you add the commit.) |
|
I will add the other commit this evening US hours.
Len
…----------------------------------------
Len Greski
Voice: 847-404-3079
Pardon the brevity, sent from mobile device
On May 23, 2017, at 12:13 PM, Sean Kross ***@***.***> wrote:
Would you mind taking the link out until the link is live? (Or I can just wait until you add the commit.)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Added the capstone.md page. |
|
@lgreski Is this ready to merge? |
|
Yes, it has been ready to merge since Tuesday when I committed capstone.md.
Regards,
Len
From: Sean Kross <[email protected]>
Reply-To: "DataScienceSpecialization/DataScienceSpecialization.github.io" <[email protected]>
Date: Saturday, May 27, 2017 at 1:40 PM
To: "DataScienceSpecialization/DataScienceSpecialization.github.io" <[email protected]>
Cc: Len Greski <[email protected]>, Mention <[email protected]>
Subject: Re: [DataScienceSpecialization/DataScienceSpecialization.github.io] Add articles to R Programming page (#130)
@lgreski Is this ready to merge?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Awesome, thanks Len! |
|
You're welcome. I apologize about the initial issue. I didn't realize that once I'd submitted a pull request, that subsequent commits to my version of the repository are automatically included in the pull. I thought I had submitted a complete package and was waiting for it to be completed before submitting the updated index and capstone pages. I"m usually pretty conscientious about making my pull requests complete units of work. |
|
@seankross looks good, Capstone page is available from the home page, correctly brings up capstone.md, and all links on capstone.md bring up the correct pages. |
|
Don't worry about it! One suggestion: you could create a separate branch for each "unit of work" and then initiate the PR from that branch. That way your commits to other branches wouldn't show up. |
|
That's a good point. Usually when I contribute content to the DSS repository the units of work are smaller, so no need for a separate branch. |
No description provided.