Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily pin i18n for JRuby #1353

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Temporarily pin i18n for JRuby #1353

merged 1 commit into from
Feb 5, 2021

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Feb 4, 2021

With the latest release of i18n (1.8.8), a bug surfaced when running under JRuby: ruby-i18n/i18n#555

The current recommendation is to stick to 1.8.7 for the time being.

This issue is affecting all commits today, and it looks like this:

NoMethodError:
  undefined method `deep_merge!' for {}:Concurrent::Hash
/usr/local/bundle/jruby/2.5.0/gems/i18n-1.8.8/lib/i18n/backend/simple.rb:45:in `store_translations'

@marcotc marcotc added the dev/testing Involves testing processes (e.g. RSpec) label Feb 4, 2021
@marcotc marcotc self-assigned this Feb 4, 2021
@marcotc marcotc requested a review from a team February 4, 2021 22:14
@marcotc marcotc changed the title Temporarily pin i18n for Ruby Temporarily pin i18n for JRuby Feb 4, 2021
@ivoanjo
Copy link
Member

ivoanjo commented Feb 5, 2021

Thank you, sir! :)

@ivoanjo ivoanjo merged commit a4aadec into master Feb 5, 2021
@ivoanjo ivoanjo deleted the jruby-i18n branch February 5, 2021 08:55
@github-actions github-actions bot added this to the 0.46.0 milestone Feb 5, 2021
This was referenced Feb 5, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivoanjo ivoanjo ivoanjo approved these changes

Assignees

@marcotc marcotc

Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Milestone
0.46.0
Development

Successfully merging this pull request may close these issues.
2 participants
@marcotc @ivoanjo