Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log injection smoke test on IBM8 #8126

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Fix log injection smoke test on IBM8 #8126

wants to merge 4 commits into from
+152 −138

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Dec 20, 2024

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@mcculls mcculls added type: bug comp: testing Testing tag: no release notes Changes to exclude from release notes run-tests: ibm8 Run tests using IBM 8 JDK run-tests: all Run all tests labels Dec 20, 2024
@mcculls mcculls force-pushed the mcculls/fix-log-injection-test branch from 4cf05c3 to 003528e Compare December 20, 2024 19:25
@pr-commenter
Copy link

pr-commenter bot commented Dec 20, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/fix-log-injection-test
git_commit_date 1734944119 1735355206
git_commit_sha 46b5986 ffca9bc
release_version 1.45.0-SNAPSHOT~46b5986f6a 1.45.0-SNAPSHOT~ffca9bcb63
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1735357707 1735357707
ci_job_id 750384662 750384662
ci_pipeline_id 51863990 51863990
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 1 performance improvements and 2 performance regressions! Performance is the same for 54 metrics, 6 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:tracing:AppSec better
[-6.387ms; -1.874ms] or [-10.771%; -3.161%]		 55.165ms 59.296ms
scenario:startup:insecure-bank:tracing:Remote Config worse
[+23.857µs; +55.046µs] or [+3.484%; +8.040%]		 724.121µs 684.669µs
scenario:startup:petclinic:profiling:Remote Config worse
[+19.986µs; +58.887µs] or [+3.047%; +8.977%]		 695.387µs 655.951µs
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~ffca9bcb63, baseline=1.45.0-SNAPSHOT~46b5986f6a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1053982
Total [baseline] (10.411 s) : 0, 10410670
Agent [candidate] (1.052 s) : 0, 1052051
Total [candidate] (10.399 s) : 0, 10399282
section appsec
Agent [baseline] (1.194 s) : 0, 1193689
Total [baseline] (10.799 s) : 0, 10799326
Agent [candidate] (1.188 s) : 0, 1187553
Total [candidate] (10.741 s) : 0, 10740643
section iast
Agent [baseline] (1.187 s) : 0, 1186762
Total [baseline] (10.986 s) : 0, 10985755
Agent [candidate] (1.183 s) : 0, 1183264
Total [candidate] (11.035 s) : 0, 11035417
section profiling
Agent [baseline] (1.275 s) : 0, 1274917
Total [baseline] (10.872 s) : 0, 10871591
Agent [candidate] (1.285 s) : 0, 1285407
Total [candidate] (10.865 s) : 0, 10865121
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent appsec 1.194 s 139.706 ms (13.3%)
Agent iast 1.187 s 132.78 ms (12.6%)
Agent profiling 1.275 s 220.935 ms (21.0%)
Total tracing 10.411 s -
Total appsec 10.799 s 388.656 ms (3.7%)
Total iast 10.986 s 575.085 ms (5.5%)
Total profiling 10.872 s 460.921 ms (4.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.052 s -
Agent appsec 1.188 s 135.502 ms (12.9%)
Agent iast 1.183 s 131.213 ms (12.5%)
Agent profiling 1.285 s 233.356 ms (22.2%)
Total tracing 10.399 s -
Total appsec 10.741 s 341.361 ms (3.3%)
Total iast 11.035 s 636.135 ms (6.1%)
Total profiling 10.865 s 465.839 ms (4.5%) 
gantt
    title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~ffca9bcb63, baseline=1.45.0-SNAPSHOT~46b5986f6a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (711.285 ms) : 0, 711285
BytebuddyAgent [candidate] (711.681 ms) : 0, 711681
GlobalTracer [baseline] (256.08 ms) : 0, 256080
GlobalTracer [candidate] (256.58 ms) : 0, 256580
AppSec [baseline] (58.412 ms) : 0, 58412
AppSec [candidate] (55.214 ms) : 0, 55214
Remote Config [baseline] (695.151 µs) : 0, 695
Remote Config [candidate] (713.556 µs) : 0, 714
Telemetry [baseline] (12.475 ms) : 0, 12475
Telemetry [candidate] (12.752 ms) : 0, 12752
section appsec
BytebuddyAgent [baseline] (732.152 ms) : 0, 732152
BytebuddyAgent [candidate] (729.553 ms) : 0, 729553
GlobalTracer [baseline] (255.286 ms) : 0, 255286
GlobalTracer [candidate] (253.737 ms) : 0, 253737
AppSec [baseline] (172.636 ms) : 0, 172636
AppSec [candidate] (170.09 ms) : 0, 170090
Remote Config [baseline] (674.188 µs) : 0, 674
Remote Config [candidate] (662.545 µs) : 0, 663
Telemetry [baseline] (8.102 ms) : 0, 8102
Telemetry [candidate] (8.672 ms) : 0, 8672
IAST [baseline] (19.731 ms) : 0, 19731
IAST [candidate] (19.495 ms) : 0, 19495
section iast
BytebuddyAgent [baseline] (834.884 ms) : 0, 834884
BytebuddyAgent [candidate] (829.821 ms) : 0, 829821
GlobalTracer [baseline] (248.087 ms) : 0, 248087
GlobalTracer [candidate] (248.903 ms) : 0, 248903
AppSec [baseline] (58.301 ms) : 0, 58301
AppSec [candidate] (58.31 ms) : 0, 58310
Remote Config [baseline] (665.356 µs) : 0, 665
Remote Config [candidate] (685.832 µs) : 0, 686
Telemetry [baseline] (8.544 ms) : 0, 8544
Telemetry [candidate] (8.659 ms) : 0, 8659
IAST [baseline] (21.275 ms) : 0, 21275
IAST [candidate] (21.717 ms) : 0, 21717
section profiling
ProfilingAgent [baseline] (96.016 ms) : 0, 96016
ProfilingAgent [candidate] (96.709 ms) : 0, 96709
BytebuddyAgent [baseline] (702.565 ms) : 0, 702565
BytebuddyAgent [candidate] (707.577 ms) : 0, 707577
GlobalTracer [baseline] (371.858 ms) : 0, 371858
GlobalTracer [candidate] (375.98 ms) : 0, 375980
AppSec [baseline] (54.2 ms) : 0, 54200
AppSec [candidate] (54.292 ms) : 0, 54292
Remote Config [baseline] (655.951 µs) : 0, 656
Remote Config [candidate] (695.387 µs) : 0, 695
Telemetry [baseline] (7.845 ms) : 0, 7845
Telemetry [candidate] (7.945 ms) : 0, 7945
Profiling [baseline] (96.04 ms) : 0, 96040
Profiling [candidate] (96.733 ms) : 0, 96733
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~ffca9bcb63, baseline=1.45.0-SNAPSHOT~46b5986f6a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055915
Total [baseline] (8.613 s) : 0, 8612804
Agent [candidate] (1.055 s) : 0, 1055495
Total [candidate] (8.645 s) : 0, 8645307
section iast
Agent [baseline] (1.177 s) : 0, 1177487
Total [baseline] (9.204 s) : 0, 9203551
Agent [candidate] (1.187 s) : 0, 1187412
Total [candidate] (9.261 s) : 0, 9261377
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.178 s) : 0, 1177973
Total [baseline] (9.23 s) : 0, 9230340
Agent [candidate] (1.205 s) : 0, 1205222
Total [candidate] (9.221 s) : 0, 9221296
section iast_TELEMETRY_OFF
Agent [baseline] (1.173 s) : 0, 1173028
Total [baseline] (9.238 s) : 0, 9238201
Agent [candidate] (1.179 s) : 0, 1178600
Total [candidate] (9.222 s) : 0, 9222275
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent iast 1.177 s 121.573 ms (11.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.178 s 122.058 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.173 s 117.113 ms (11.1%)
Total tracing 8.613 s -
Total iast 9.204 s 590.747 ms (6.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.23 s 617.536 ms (7.2%)
Total iast_TELEMETRY_OFF 9.238 s 625.397 ms (7.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent iast 1.187 s 131.917 ms (12.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.205 s 149.727 ms (14.2%)
Agent iast_TELEMETRY_OFF 1.179 s 123.105 ms (11.7%)
Total tracing 8.645 s -
Total iast 9.261 s 616.07 ms (7.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.221 s 575.989 ms (6.7%)
Total iast_TELEMETRY_OFF 9.222 s 576.968 ms (6.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~ffca9bcb63, baseline=1.45.0-SNAPSHOT~46b5986f6a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.765 ms) : 0, 713765
BytebuddyAgent [candidate] (713.248 ms) : 0, 713248
GlobalTracer [baseline] (256.16 ms) : 0, 256160
GlobalTracer [candidate] (257.782 ms) : 0, 257782
AppSec [baseline] (59.296 ms) : 0, 59296
AppSec [candidate] (55.165 ms) : 0, 55165
Remote Config [baseline] (684.669 µs) : 0, 685
Remote Config [candidate] (724.121 µs) : 0, 724
Telemetry [baseline] (11.129 ms) : 0, 11129
Telemetry [candidate] (13.463 ms) : 0, 13463
section iast
BytebuddyAgent [baseline] (828.548 ms) : 0, 828548
BytebuddyAgent [candidate] (834.58 ms) : 0, 834580
GlobalTracer [baseline] (246.108 ms) : 0, 246108
GlobalTracer [candidate] (248.501 ms) : 0, 248501
AppSec [baseline] (57.719 ms) : 0, 57719
AppSec [candidate] (58.252 ms) : 0, 58252
IAST [baseline] (21.126 ms) : 0, 21126
IAST [candidate] (21.665 ms) : 0, 21665
Remote Config [baseline] (643.635 µs) : 0, 644
Remote Config [candidate] (667.204 µs) : 0, 667
Telemetry [baseline] (8.487 ms) : 0, 8487
Telemetry [candidate] (8.689 ms) : 0, 8689
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (828.263 ms) : 0, 828263
BytebuddyAgent [candidate] (847.138 ms) : 0, 847138
GlobalTracer [baseline] (246.575 ms) : 0, 246575
GlobalTracer [candidate] (251.541 ms) : 0, 251541
AppSec [baseline] (57.824 ms) : 0, 57824
AppSec [candidate] (59.478 ms) : 0, 59478
IAST [baseline] (21.235 ms) : 0, 21235
IAST [candidate] (22.148 ms) : 0, 22148
Remote Config [baseline] (659.909 µs) : 0, 660
Remote Config [candidate] (700.001 µs) : 0, 700
Telemetry [baseline] (8.48 ms) : 0, 8480
Telemetry [candidate] (8.843 ms) : 0, 8843
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (824.507 ms) : 0, 824507
BytebuddyAgent [candidate] (828.274 ms) : 0, 828274
GlobalTracer [baseline] (246.29 ms) : 0, 246290
GlobalTracer [candidate] (247.484 ms) : 0, 247484
AppSec [baseline] (57.854 ms) : 0, 57854
AppSec [candidate] (57.831 ms) : 0, 57831
IAST [baseline] (20.556 ms) : 0, 20556
IAST [candidate] (20.85 ms) : 0, 20850
Remote Config [baseline] (648.85 µs) : 0, 649
Remote Config [candidate] (662.444 µs) : 0, 662
Telemetry [baseline] (8.244 ms) : 0, 8244
Telemetry [candidate] (8.387 ms) : 0, 8387
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-12-28T03:18:43 2024-12-28T03:25:43
git_branch master mcculls/fix-log-injection-test
git_commit_date 1734944119 1735355206
git_commit_sha 46b5986 ffca9bc
release_version 1.45.0-SNAPSHOT~46b5986f6a 1.45.0-SNAPSHOT~ffca9bcb63
start_time 2024-12-28T03:18:30 2024-12-28T03:25:29
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1735356696 1735356696
ci_job_id 750384663 750384663
ci_pipeline_id 51863990 51863990
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling better
[-94.861µs; -44.450µs] or [-5.988%; -2.806%]		 unstable
[-428.265op/s; +656.186op/s] or [-14.454%; +22.146%]		 1.515ms 3076.923op/s 1.584ms 2962.963op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~ffca9bcb63, baseline=1.45.0-SNAPSHOT~46b5986f6a
    dateFormat X
    axisFormat %s
section baseline
no_agent (383.525 µs) : 363, 404
.   : milestone, 384,
iast (500.743 µs) : 479, 523
.   : milestone, 501,
iast_FULL (658.89 µs) : 637, 681
.   : milestone, 659,
iast_GLOBAL (527.133 µs) : 505, 549
.   : milestone, 527,
iast_HARDCODED_SECRET_DISABLED (491.381 µs) : 470, 513
.   : milestone, 491,
iast_INACTIVE (456.995 µs) : 435, 479
.   : milestone, 457,
iast_TELEMETRY_OFF (490.167 µs) : 469, 512
.   : milestone, 490,
tracing (449.404 µs) : 428, 470
.   : milestone, 449,
section candidate
no_agent (372.236 µs) : 352, 392
.   : milestone, 372,
iast (503.279 µs) : 481, 526
.   : milestone, 503,
iast_FULL (651.657 µs) : 630, 673
.   : milestone, 652,
iast_GLOBAL (523.747 µs) : 502, 546
.   : milestone, 524,
iast_HARDCODED_SECRET_DISABLED (492.9 µs) : 472, 514
.   : milestone, 493,
iast_INACTIVE (461.866 µs) : 440, 484
.   : milestone, 462,
iast_TELEMETRY_OFF (483.976 µs) : 462, 506
.   : milestone, 484,
tracing (443.989 µs) : 423, 465
.   : milestone, 444,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 383.525 µs [362.766 µs, 404.285 µs] -
iast 500.743 µs [478.824 µs, 522.662 µs] 117.218 µs (30.6%)
iast_FULL 658.89 µs [637.132 µs, 680.648 µs] 275.364 µs (71.8%)
iast_GLOBAL 527.133 µs [504.861 µs, 549.404 µs] 143.608 µs (37.4%)
iast_HARDCODED_SECRET_DISABLED 491.381 µs [470.005 µs, 512.757 µs] 107.855 µs (28.1%)
iast_INACTIVE 456.995 µs [434.781 µs, 479.21 µs] 73.47 µs (19.2%)
iast_TELEMETRY_OFF 490.167 µs [468.678 µs, 511.657 µs] 106.642 µs (27.8%)
tracing 449.404 µs [428.35 µs, 470.458 µs] 65.878 µs (17.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.236 µs [352.126 µs, 392.346 µs] -
iast 503.279 µs [480.64 µs, 525.918 µs] 131.043 µs (35.2%)
iast_FULL 651.657 µs [630.055 µs, 673.258 µs] 279.421 µs (75.1%)
iast_GLOBAL 523.747 µs [501.676 µs, 545.818 µs] 151.511 µs (40.7%)
iast_HARDCODED_SECRET_DISABLED 492.9 µs [471.514 µs, 514.287 µs] 120.664 µs (32.4%)
iast_INACTIVE 461.866 µs [440.209 µs, 483.523 µs] 89.63 µs (24.1%)
iast_TELEMETRY_OFF 483.976 µs [462.2 µs, 505.752 µs] 111.741 µs (30.0%)
tracing 443.989 µs [423.289 µs, 464.688 µs] 71.753 µs (19.3%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~ffca9bcb63, baseline=1.45.0-SNAPSHOT~46b5986f6a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.335 ms) : 1316, 1354
.   : milestone, 1335,
appsec (1.736 ms) : 1712, 1760
.   : milestone, 1736,
appsec_no_iast (1.745 ms) : 1720, 1769
.   : milestone, 1745,
iast (1.502 ms) : 1479, 1525
.   : milestone, 1502,
profiling (1.584 ms) : 1560, 1608
.   : milestone, 1584,
tracing (1.476 ms) : 1451, 1501
.   : milestone, 1476,
section candidate
no_agent (1.365 ms) : 1346, 1384
.   : milestone, 1365,
appsec (1.745 ms) : 1721, 1769
.   : milestone, 1745,
appsec_no_iast (1.761 ms) : 1737, 1785
.   : milestone, 1761,
iast (1.5 ms) : 1477, 1523
.   : milestone, 1500,
profiling (1.515 ms) : 1492, 1537
.   : milestone, 1515,
tracing (1.478 ms) : 1454, 1503
.   : milestone, 1478,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.335 ms [1.316 ms, 1.354 ms] -
appsec 1.736 ms [1.712 ms, 1.76 ms] 400.717 µs (30.0%)
appsec_no_iast 1.745 ms [1.72 ms, 1.769 ms] 409.584 µs (30.7%)
iast 1.502 ms [1.479 ms, 1.525 ms] 166.918 µs (12.5%)
profiling 1.584 ms [1.56 ms, 1.608 ms] 249.164 µs (18.7%)
tracing 1.476 ms [1.451 ms, 1.501 ms] 140.962 µs (10.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.365 ms [1.346 ms, 1.384 ms] -
appsec 1.745 ms [1.721 ms, 1.769 ms] 379.759 µs (27.8%)
appsec_no_iast 1.761 ms [1.737 ms, 1.785 ms] 396.054 µs (29.0%)
iast 1.5 ms [1.477 ms, 1.523 ms] 134.676 µs (9.9%)
profiling 1.515 ms [1.492 ms, 1.537 ms] 149.635 µs (11.0%)
tracing 1.478 ms [1.454 ms, 1.503 ms] 113.424 µs (8.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/fix-log-injection-test
git_commit_date 1734944119 1735355206
git_commit_sha 46b5986 ffca9bc
release_version 1.45.0-SNAPSHOT~46b5986f6a 1.45.0-SNAPSHOT~ffca9bcb63
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1735357253 1735357253
ci_job_id 750384664 750384664
ci_pipeline_id 51863990 51863990
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~ffca9bcb63, baseline=1.45.0-SNAPSHOT~46b5986f6a
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.478 s) : 15478000, 15478000
.   : milestone, 15478000,
appsec (15.02 s) : 15020000, 15020000
.   : milestone, 15020000,
iast (19.016 s) : 19016000, 19016000
.   : milestone, 19016000,
iast_GLOBAL (18.027 s) : 18027000, 18027000
.   : milestone, 18027000,
profiling (14.963 s) : 14963000, 14963000
.   : milestone, 14963000,
tracing (14.968 s) : 14968000, 14968000
.   : milestone, 14968000,
section candidate
no_agent (15.444 s) : 15444000, 15444000
.   : milestone, 15444000,
appsec (15.13 s) : 15130000, 15130000
.   : milestone, 15130000,
iast (19.126 s) : 19126000, 19126000
.   : milestone, 19126000,
iast_GLOBAL (17.579 s) : 17579000, 17579000
.   : milestone, 17579000,
profiling (15.128 s) : 15128000, 15128000
.   : milestone, 15128000,
tracing (15.147 s) : 15147000, 15147000
.   : milestone, 15147000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.478 s [15.478 s, 15.478 s] -
appsec 15.02 s [15.02 s, 15.02 s] -458.0 ms (-3.0%)
iast 19.016 s [19.016 s, 19.016 s] 3.538 s (22.9%)
iast_GLOBAL 18.027 s [18.027 s, 18.027 s] 2.549 s (16.5%)
profiling 14.963 s [14.963 s, 14.963 s] -515.0 ms (-3.3%)
tracing 14.968 s [14.968 s, 14.968 s] -510.0 ms (-3.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.444 s [15.444 s, 15.444 s] -
appsec 15.13 s [15.13 s, 15.13 s] -314.0 ms (-2.0%)
iast 19.126 s [19.126 s, 19.126 s] 3.682 s (23.8%)
iast_GLOBAL 17.579 s [17.579 s, 17.579 s] 2.135 s (13.8%)
profiling 15.128 s [15.128 s, 15.128 s] -316.0 ms (-2.0%)
tracing 15.147 s [15.147 s, 15.147 s] -297.0 ms (-1.9%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~ffca9bcb63, baseline=1.45.0-SNAPSHOT~46b5986f6a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
.   : milestone, 1478,
appsec (2.359 ms) : 2317, 2401
.   : milestone, 2359,
iast (2.099 ms) : 2046, 2152
.   : milestone, 2099,
iast_GLOBAL (2.151 ms) : 2098, 2205
.   : milestone, 2151,
profiling (2.413 ms) : 2236, 2590
.   : milestone, 2413,
tracing (1.936 ms) : 1896, 1977
.   : milestone, 1936,
section candidate
no_agent (1.475 ms) : 1464, 1487
.   : milestone, 1475,
appsec (2.358 ms) : 2316, 2400
.   : milestone, 2358,
iast (2.101 ms) : 2048, 2154
.   : milestone, 2101,
iast_GLOBAL (2.148 ms) : 2094, 2201
.   : milestone, 2148,
profiling (1.972 ms) : 1930, 2014
.   : milestone, 1972,
tracing (1.94 ms) : 1899, 1980
.   : milestone, 1940,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.478 ms [1.466 ms, 1.489 ms] -
appsec 2.359 ms [2.317 ms, 2.401 ms] 881.259 µs (59.6%)
iast 2.099 ms [2.046 ms, 2.152 ms] 621.177 µs (42.0%)
iast_GLOBAL 2.151 ms [2.098 ms, 2.205 ms] 673.411 µs (45.6%)
profiling 2.413 ms [2.236 ms, 2.59 ms] 935.137 µs (63.3%)
tracing 1.936 ms [1.896 ms, 1.977 ms] 458.479 µs (31.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.475 ms [1.464 ms, 1.487 ms] -
appsec 2.358 ms [2.316 ms, 2.4 ms] 882.482 µs (59.8%)
iast 2.101 ms [2.048 ms, 2.154 ms] 625.244 µs (42.4%)
iast_GLOBAL 2.148 ms [2.094 ms, 2.201 ms] 672.112 µs (45.6%)
profiling 1.972 ms [1.93 ms, 2.014 ms] 496.555 µs (33.7%)
tracing 1.94 ms [1.899 ms, 1.98 ms] 464.259 µs (31.5%)

@mcculls mcculls removed the run-tests: all Run all tests label Dec 20, 2024
@mcculls mcculls force-pushed the mcculls/fix-log-injection-test branch from ed01097 to a77a5e1 Compare December 21, 2024 18:50
@mcculls mcculls changed the title Wait for initial config to appear before starting test Fix log injection smoke test on IBM8 Dec 21, 2024
@mcculls mcculls force-pushed the mcculls/fix-log-injection-test branch 10 times, most recently from 2279f72 to d3ed23d Compare December 23, 2024 23:51
@mcculls
Remove exemption where we didn't defer if the custom logging manager
71886d7 
or JMX builder was on the system classpath (because the main thread
would find it there if OkHttp triggered initialization of JUL.).

We now make OkHttp calls from our own background threads, which are
isolated from the system classloader, not the main thread - so this
exemption no longer makes sense.
@mcculls
Move SharedCommunicationObjects creation to InstallDatadogTracerCallb…
4709f62 
…ack constructor
@mcculls mcculls force-pushed the mcculls/fix-log-injection-test branch 5 times, most recently from e9292e0 to f1ff830 Compare December 28, 2024 00:55
@mcculls mcculls force-pushed the mcculls/fix-log-injection-test branch from f1ff830 to fe39745 Compare December 28, 2024 01:06
@mcculls mcculls force-pushed the mcculls/fix-log-injection-test branch from 551a255 to ffca9bc Compare December 28, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comp: testing Testing run-tests: ibm8 Run tests using IBM 8 JDK tag: no release notes Changes to exclude from release notes type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mcculls