-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to java-dogstatsd-client v4.4.3 #8096
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~6d35dc2dfb, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1088577
Total [baseline] (10.392 s) : 0, 10392225
Agent [candidate] (1.092 s) : 0, 1091659
Total [candidate] (10.384 s) : 0, 10383924
section appsec
Agent [baseline] (1.225 s) : 0, 1224731
Total [baseline] (10.652 s) : 0, 10651877
Agent [candidate] (1.234 s) : 0, 1233624
Total [candidate] (10.679 s) : 0, 10679418
section iast
Agent [baseline] (1.22 s) : 0, 1220009
Total [baseline] (10.947 s) : 0, 10946640
Agent [candidate] (1.222 s) : 0, 1221792
Total [candidate] (10.996 s) : 0, 10996471
section profiling
Agent [baseline] (1.312 s) : 0, 1312477
Total [baseline] (10.746 s) : 0, 10745663
Agent [candidate] (1.33 s) : 0, 1329537
Total [candidate] (10.889 s) : 0, 10889486
gantt
title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~6d35dc2dfb, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.742 ms) : 0, 693742
BytebuddyAgent [candidate] (694.44 ms) : 0, 694440
GlobalTracer [baseline] (316.29 ms) : 0, 316290
GlobalTracer [candidate] (316.491 ms) : 0, 316491
AppSec [baseline] (54.339 ms) : 0, 54339
AppSec [candidate] (54.941 ms) : 0, 54941
Remote Config [baseline] (671.115 µs) : 0, 671
Remote Config [candidate] (691.583 µs) : 0, 692
Telemetry [baseline] (9.861 ms) : 0, 9861
Telemetry [candidate] (11.382 ms) : 0, 11382
section appsec
BytebuddyAgent [baseline] (712.513 ms) : 0, 712513
BytebuddyAgent [candidate] (717.225 ms) : 0, 717225
GlobalTracer [baseline] (313.746 ms) : 0, 313746
GlobalTracer [candidate] (315.841 ms) : 0, 315841
AppSec [baseline] (166.169 ms) : 0, 166169
AppSec [candidate] (168.142 ms) : 0, 168142
Remote Config [baseline] (628.909 µs) : 0, 629
Remote Config [candidate] (638.069 µs) : 0, 638
Telemetry [baseline] (7.413 ms) : 0, 7413
Telemetry [candidate] (8.488 ms) : 0, 8488
IAST [baseline] (21.137 ms) : 0, 21137
IAST [candidate] (19.053 ms) : 0, 19053
section iast
BytebuddyAgent [baseline] (812.95 ms) : 0, 812950
BytebuddyAgent [candidate] (814.197 ms) : 0, 814197
GlobalTracer [baseline] (306.285 ms) : 0, 306285
GlobalTracer [candidate] (306.549 ms) : 0, 306549
AppSec [baseline] (57.202 ms) : 0, 57202
AppSec [candidate] (58.004 ms) : 0, 58004
Remote Config [baseline] (610.374 µs) : 0, 610
Remote Config [candidate] (644.966 µs) : 0, 645
Telemetry [baseline] (7.498 ms) : 0, 7498
Telemetry [candidate] (7.471 ms) : 0, 7471
IAST [baseline] (21.727 ms) : 0, 21727
IAST [candidate] (21.19 ms) : 0, 21190
section profiling
ProfilingAgent [baseline] (93.096 ms) : 0, 93096
ProfilingAgent [candidate] (94.669 ms) : 0, 94669
BytebuddyAgent [baseline] (687.069 ms) : 0, 687069
BytebuddyAgent [candidate] (698.134 ms) : 0, 698134
GlobalTracer [baseline] (431.292 ms) : 0, 431292
GlobalTracer [candidate] (434.425 ms) : 0, 434425
AppSec [baseline] (53.501 ms) : 0, 53501
AppSec [candidate] (53.837 ms) : 0, 53837
Remote Config [baseline] (664.117 µs) : 0, 664
Remote Config [candidate] (680.78 µs) : 0, 681
Telemetry [baseline] (7.712 ms) : 0, 7712
Telemetry [candidate] (7.828 ms) : 0, 7828
Profiling [baseline] (93.12 ms) : 0, 93120
Profiling [candidate] (94.695 ms) : 0, 94695
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~6d35dc2dfb, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.103 s) : 0, 1103177
Total [baseline] (8.66 s) : 0, 8659940
Agent [candidate] (1.092 s) : 0, 1091604
Total [candidate] (8.598 s) : 0, 8598036
section iast
Agent [baseline] (1.221 s) : 0, 1221250
Total [baseline] (9.193 s) : 0, 9192616
Agent [candidate] (1.231 s) : 0, 1230977
Total [candidate] (9.192 s) : 0, 9192119
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.22 s) : 0, 1219624
Total [baseline] (9.131 s) : 0, 9131235
Agent [candidate] (1.23 s) : 0, 1230492
Total [candidate] (9.184 s) : 0, 9184232
section iast_TELEMETRY_OFF
Agent [baseline] (1.23 s) : 0, 1229973
Total [baseline] (9.224 s) : 0, 9224130
Agent [candidate] (1.223 s) : 0, 1223491
Total [candidate] (9.129 s) : 0, 9129067
gantt
title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~6d35dc2dfb, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (701.473 ms) : 0, 701473
BytebuddyAgent [candidate] (696.241 ms) : 0, 696241
GlobalTracer [baseline] (318.838 ms) : 0, 318838
GlobalTracer [candidate] (316.864 ms) : 0, 316864
AppSec [baseline] (54.978 ms) : 0, 54978
AppSec [candidate] (54.746 ms) : 0, 54746
Remote Config [baseline] (684.254 µs) : 0, 684
Remote Config [candidate] (679.957 µs) : 0, 680
Telemetry [baseline] (13.358 ms) : 0, 13358
Telemetry [candidate] (9.308 ms) : 0, 9308
section iast
BytebuddyAgent [baseline] (813.452 ms) : 0, 813452
BytebuddyAgent [candidate] (824.605 ms) : 0, 824605
GlobalTracer [baseline] (306.681 ms) : 0, 306681
GlobalTracer [candidate] (305.834 ms) : 0, 305834
AppSec [baseline] (57.316 ms) : 0, 57316
AppSec [candidate] (57.709 ms) : 0, 57709
IAST [baseline] (22.002 ms) : 0, 22002
IAST [candidate] (20.842 ms) : 0, 20842
Remote Config [baseline] (615.136 µs) : 0, 615
Remote Config [candidate] (615.086 µs) : 0, 615
Telemetry [baseline] (7.483 ms) : 0, 7483
Telemetry [candidate] (7.44 ms) : 0, 7440
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (812.872 ms) : 0, 812872
BytebuddyAgent [candidate] (820.17 ms) : 0, 820170
GlobalTracer [baseline] (305.652 ms) : 0, 305652
GlobalTracer [candidate] (308.586 ms) : 0, 308586
AppSec [baseline] (57.403 ms) : 0, 57403
AppSec [candidate] (57.635 ms) : 0, 57635
IAST [baseline] (21.864 ms) : 0, 21864
IAST [candidate] (22.114 ms) : 0, 22114
Remote Config [baseline] (617.14 µs) : 0, 617
Remote Config [candidate] (618.672 µs) : 0, 619
Telemetry [baseline] (7.487 ms) : 0, 7487
Telemetry [candidate] (7.503 ms) : 0, 7503
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (820.88 ms) : 0, 820880
BytebuddyAgent [candidate] (815.546 ms) : 0, 815546
GlobalTracer [baseline] (307.897 ms) : 0, 307897
GlobalTracer [candidate] (306.959 ms) : 0, 306959
AppSec [baseline] (58.302 ms) : 0, 58302
AppSec [candidate] (57.425 ms) : 0, 57425
IAST [baseline] (20.876 ms) : 0, 20876
IAST [candidate] (21.69 ms) : 0, 21690
Remote Config [baseline] (633.033 µs) : 0, 633
Remote Config [candidate] (620.896 µs) : 0, 621
Telemetry [baseline] (7.514 ms) : 0, 7514
Telemetry [candidate] (7.404 ms) : 0, 7404
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~6d35dc2dfb, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section baseline
no_agent (382.106 µs) : 362, 402
. : milestone, 382,
iast (498.151 µs) : 477, 520
. : milestone, 498,
iast_FULL (658.175 µs) : 637, 680
. : milestone, 658,
iast_GLOBAL (521.61 µs) : 500, 543
. : milestone, 522,
iast_HARDCODED_SECRET_DISABLED (500.051 µs) : 479, 521
. : milestone, 500,
iast_INACTIVE (457.024 µs) : 436, 478
. : milestone, 457,
iast_TELEMETRY_OFF (481.461 µs) : 460, 503
. : milestone, 481,
tracing (463.975 µs) : 443, 485
. : milestone, 464,
section candidate
no_agent (381.654 µs) : 362, 402
. : milestone, 382,
iast (497.819 µs) : 476, 520
. : milestone, 498,
iast_FULL (663.887 µs) : 642, 685
. : milestone, 664,
iast_GLOBAL (527.008 µs) : 505, 549
. : milestone, 527,
iast_HARDCODED_SECRET_DISABLED (499.204 µs) : 478, 521
. : milestone, 499,
iast_INACTIVE (458.305 µs) : 438, 479
. : milestone, 458,
iast_TELEMETRY_OFF (487.583 µs) : 466, 509
. : milestone, 488,
tracing (456.193 µs) : 435, 477
. : milestone, 456,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~6d35dc2dfb, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section baseline
no_agent (1.352 ms) : 1332, 1372
. : milestone, 1352,
appsec (1.772 ms) : 1749, 1796
. : milestone, 1772,
appsec_no_iast (1.783 ms) : 1759, 1808
. : milestone, 1783,
iast (1.506 ms) : 1483, 1529
. : milestone, 1506,
profiling (1.509 ms) : 1486, 1531
. : milestone, 1509,
tracing (1.503 ms) : 1479, 1528
. : milestone, 1503,
section candidate
no_agent (1.391 ms) : 1371, 1411
. : milestone, 1391,
appsec (1.769 ms) : 1745, 1793
. : milestone, 1769,
appsec_no_iast (1.778 ms) : 1753, 1803
. : milestone, 1778,
iast (1.506 ms) : 1483, 1529
. : milestone, 1506,
profiling (1.521 ms) : 1498, 1544
. : milestone, 1521,
tracing (1.485 ms) : 1459, 1510
. : milestone, 1485,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~6d35dc2dfb, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1479
. : milestone, 1467,
appsec (2.341 ms) : 2300, 2382
. : milestone, 2341,
iast (2.092 ms) : 2039, 2145
. : milestone, 2092,
iast_GLOBAL (2.133 ms) : 2079, 2186
. : milestone, 2133,
profiling (1.965 ms) : 1922, 2008
. : milestone, 1965,
tracing (1.928 ms) : 1888, 1969
. : milestone, 1928,
section candidate
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.349 ms) : 2307, 2391
. : milestone, 2349,
iast (2.095 ms) : 2042, 2148
. : milestone, 2095,
iast_GLOBAL (2.142 ms) : 2088, 2195
. : milestone, 2142,
profiling (1.962 ms) : 1918, 2005
. : milestone, 1962,
tracing (1.931 ms) : 1890, 1972
. : milestone, 1931,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~6d35dc2dfb, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section baseline
no_agent (14.848 s) : 14848000, 14848000
. : milestone, 14848000,
appsec (14.896 s) : 14896000, 14896000
. : milestone, 14896000,
iast (18.584 s) : 18584000, 18584000
. : milestone, 18584000,
iast_GLOBAL (17.753 s) : 17753000, 17753000
. : milestone, 17753000,
profiling (14.839 s) : 14839000, 14839000
. : milestone, 14839000,
tracing (15.157 s) : 15157000, 15157000
. : milestone, 15157000,
section candidate
no_agent (14.914 s) : 14914000, 14914000
. : milestone, 14914000,
appsec (15.155 s) : 15155000, 15155000
. : milestone, 15155000,
iast (19.035 s) : 19035000, 19035000
. : milestone, 19035000,
iast_GLOBAL (17.749 s) : 17749000, 17749000
. : milestone, 17749000,
profiling (15.204 s) : 15204000, 15204000
. : milestone, 15204000,
tracing (15.028 s) : 15028000, 15028000
. : milestone, 15028000,
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Motivation
Additional Notes
The following changes are also included, but have no effect because of the way we configure
java-dogstatsd-client
address
builder method.Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]