-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the possibility to output the logs of the Java tracer in JSON #8083
base: master
Are you sure you want to change the base?
Conversation
Hi! 👋 Looks like you updated a Git Submodule.
|
Hi! 👋 Looks like you updated a Git Submodule.
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 3 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~e4c4b13fc4, baseline=1.45.0-SNAPSHOT~46b5986f6a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1061908
Total [baseline] (8.639 s) : 0, 8639158
Agent [candidate] (1.054 s) : 0, 1054398
Total [candidate] (8.654 s) : 0, 8653947
section iast
Agent [baseline] (1.178 s) : 0, 1178209
Total [baseline] (9.249 s) : 0, 9248543
Agent [candidate] (1.181 s) : 0, 1181166
Total [candidate] (9.188 s) : 0, 9188028
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.176 s) : 0, 1175786
Total [baseline] (9.222 s) : 0, 9222099
Agent [candidate] (1.191 s) : 0, 1190519
Total [candidate] (9.316 s) : 0, 9316114
section iast_TELEMETRY_OFF
Agent [baseline] (1.173 s) : 0, 1173148
Total [baseline] (9.234 s) : 0, 9234031
Agent [candidate] (1.175 s) : 0, 1175477
Total [candidate] (9.229 s) : 0, 9228549
gantt
title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~e4c4b13fc4, baseline=1.45.0-SNAPSHOT~46b5986f6a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.053 ms) : 0, 718053
BytebuddyAgent [candidate] (711.932 ms) : 0, 711932
GlobalTracer [baseline] (257.863 ms) : 0, 257863
GlobalTracer [candidate] (256.129 ms) : 0, 256129
AppSec [baseline] (57.504 ms) : 0, 57504
AppSec [candidate] (55.71 ms) : 0, 55710
Remote Config [baseline] (695.71 µs) : 0, 696
Remote Config [candidate] (693.452 µs) : 0, 693
Telemetry [baseline] (12.701 ms) : 0, 12701
Telemetry [candidate] (15.036 ms) : 0, 15036
section iast
BytebuddyAgent [baseline] (829.152 ms) : 0, 829152
BytebuddyAgent [candidate] (831.158 ms) : 0, 831158
GlobalTracer [baseline] (246.376 ms) : 0, 246376
GlobalTracer [candidate] (247.063 ms) : 0, 247063
AppSec [baseline] (57.512 ms) : 0, 57512
AppSec [candidate] (57.739 ms) : 0, 57739
IAST [baseline] (21.141 ms) : 0, 21141
IAST [candidate] (21.21 ms) : 0, 21210
Remote Config [baseline] (652.259 µs) : 0, 652
Remote Config [candidate] (653.247 µs) : 0, 653
Telemetry [baseline] (8.434 ms) : 0, 8434
Telemetry [candidate] (8.474 ms) : 0, 8474
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (825.996 ms) : 0, 825996
BytebuddyAgent [candidate] (837.168 ms) : 0, 837168
GlobalTracer [baseline] (246.218 ms) : 0, 246218
GlobalTracer [candidate] (249.165 ms) : 0, 249165
AppSec [baseline] (58.46 ms) : 0, 58460
AppSec [candidate] (58.409 ms) : 0, 58409
IAST [baseline] (21.093 ms) : 0, 21093
IAST [candidate] (21.305 ms) : 0, 21305
Remote Config [baseline] (657.305 µs) : 0, 657
Remote Config [candidate] (672.608 µs) : 0, 673
Telemetry [baseline] (8.533 ms) : 0, 8533
Telemetry [candidate] (8.56 ms) : 0, 8560
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (824.678 ms) : 0, 824678
BytebuddyAgent [candidate] (826.744 ms) : 0, 826744
GlobalTracer [baseline] (246.617 ms) : 0, 246617
GlobalTracer [candidate] (246.987 ms) : 0, 246987
AppSec [baseline] (57.418 ms) : 0, 57418
AppSec [candidate] (57.287 ms) : 0, 57287
IAST [baseline] (20.63 ms) : 0, 20630
IAST [candidate] (20.524 ms) : 0, 20524
Remote Config [baseline] (646.678 µs) : 0, 647
Remote Config [candidate] (653.932 µs) : 0, 654
Telemetry [baseline] (8.271 ms) : 0, 8271
Telemetry [candidate] (8.283 ms) : 0, 8283
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~e4c4b13fc4, baseline=1.45.0-SNAPSHOT~46b5986f6a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061471
Total [baseline] (10.435 s) : 0, 10435252
Agent [candidate] (1.057 s) : 0, 1057125
Total [candidate] (10.505 s) : 0, 10504803
section appsec
Agent [baseline] (1.192 s) : 0, 1191956
Total [baseline] (10.736 s) : 0, 10736314
Agent [candidate] (1.186 s) : 0, 1186434
Total [candidate] (10.707 s) : 0, 10707071
section iast
Agent [baseline] (1.178 s) : 0, 1178226
Total [baseline] (11.022 s) : 0, 11021545
Agent [candidate] (1.182 s) : 0, 1181683
Total [candidate] (11.049 s) : 0, 11049358
section profiling
Agent [baseline] (1.274 s) : 0, 1273598
Total [baseline] (10.883 s) : 0, 10883369
Agent [candidate] (1.273 s) : 0, 1272527
Total [candidate] (10.96 s) : 0, 10959627
gantt
title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~e4c4b13fc4, baseline=1.45.0-SNAPSHOT~46b5986f6a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.841 ms) : 0, 717841
BytebuddyAgent [candidate] (713.366 ms) : 0, 713366
GlobalTracer [baseline] (257.836 ms) : 0, 257836
GlobalTracer [candidate] (256.879 ms) : 0, 256879
AppSec [baseline] (58.973 ms) : 0, 58973
AppSec [candidate] (57.052 ms) : 0, 57052
Remote Config [baseline] (701.872 µs) : 0, 702
Remote Config [candidate] (696.403 µs) : 0, 696
Telemetry [baseline] (11.141 ms) : 0, 11141
Telemetry [candidate] (14.157 ms) : 0, 14157
section appsec
BytebuddyAgent [baseline] (732.4 ms) : 0, 732400
BytebuddyAgent [candidate] (729.015 ms) : 0, 729015
GlobalTracer [baseline] (254.417 ms) : 0, 254417
GlobalTracer [candidate] (253.014 ms) : 0, 253014
AppSec [baseline] (171.757 ms) : 0, 171757
AppSec [candidate] (171.188 ms) : 0, 171188
IAST [baseline] (19.659 ms) : 0, 19659
IAST [candidate] (19.272 ms) : 0, 19272
Remote Config [baseline] (656.209 µs) : 0, 656
Remote Config [candidate] (654.977 µs) : 0, 655
Telemetry [baseline] (7.986 ms) : 0, 7986
Telemetry [candidate] (7.97 ms) : 0, 7970
section iast
BytebuddyAgent [baseline] (828.494 ms) : 0, 828494
BytebuddyAgent [candidate] (830.824 ms) : 0, 830824
GlobalTracer [baseline] (246.729 ms) : 0, 246729
GlobalTracer [candidate] (247.565 ms) : 0, 247565
AppSec [baseline] (57.875 ms) : 0, 57875
AppSec [candidate] (57.98 ms) : 0, 57980
IAST [baseline] (21.175 ms) : 0, 21175
IAST [candidate] (21.106 ms) : 0, 21106
Remote Config [baseline] (662.92 µs) : 0, 663
Remote Config [candidate] (665.55 µs) : 0, 666
Telemetry [baseline] (8.444 ms) : 0, 8444
Telemetry [candidate] (8.574 ms) : 0, 8574
section profiling
BytebuddyAgent [baseline] (701.252 ms) : 0, 701252
BytebuddyAgent [candidate] (701.374 ms) : 0, 701374
GlobalTracer [baseline] (372.156 ms) : 0, 372156
GlobalTracer [candidate] (370.947 ms) : 0, 370947
AppSec [baseline] (54.336 ms) : 0, 54336
AppSec [candidate] (54.075 ms) : 0, 54075
Remote Config [baseline] (662.092 µs) : 0, 662
Remote Config [candidate] (670.232 µs) : 0, 670
Telemetry [baseline] (7.835 ms) : 0, 7835
Telemetry [candidate] (7.786 ms) : 0, 7786
ProfilingAgent [baseline] (95.799 ms) : 0, 95799
ProfilingAgent [candidate] (96.013 ms) : 0, 96013
Profiling [baseline] (95.823 ms) : 0, 95823
Profiling [candidate] (96.036 ms) : 0, 96036
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~e4c4b13fc4, baseline=1.45.0-SNAPSHOT~46b5986f6a
dateFormat X
axisFormat %s
section baseline
no_agent (386.317 µs) : 365, 408
. : milestone, 386,
iast (500.051 µs) : 478, 522
. : milestone, 500,
iast_FULL (659.534 µs) : 638, 681
. : milestone, 660,
iast_GLOBAL (534.799 µs) : 512, 558
. : milestone, 535,
iast_HARDCODED_SECRET_DISABLED (491.345 µs) : 470, 512
. : milestone, 491,
iast_INACTIVE (457.906 µs) : 437, 479
. : milestone, 458,
iast_TELEMETRY_OFF (483.936 µs) : 462, 505
. : milestone, 484,
tracing (454.329 µs) : 433, 476
. : milestone, 454,
section candidate
no_agent (373.81 µs) : 354, 394
. : milestone, 374,
iast (494.415 µs) : 473, 516
. : milestone, 494,
iast_FULL (654.769 µs) : 633, 676
. : milestone, 655,
iast_GLOBAL (535.956 µs) : 512, 560
. : milestone, 536,
iast_HARDCODED_SECRET_DISABLED (492.862 µs) : 472, 514
. : milestone, 493,
iast_INACTIVE (455.427 µs) : 435, 476
. : milestone, 455,
iast_TELEMETRY_OFF (482.151 µs) : 461, 504
. : milestone, 482,
tracing (458.445 µs) : 437, 480
. : milestone, 458,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~e4c4b13fc4, baseline=1.45.0-SNAPSHOT~46b5986f6a
dateFormat X
axisFormat %s
section baseline
no_agent (1.356 ms) : 1337, 1376
. : milestone, 1356,
appsec (1.748 ms) : 1724, 1771
. : milestone, 1748,
appsec_no_iast (1.765 ms) : 1739, 1790
. : milestone, 1765,
iast (1.497 ms) : 1475, 1520
. : milestone, 1497,
profiling (1.526 ms) : 1502, 1550
. : milestone, 1526,
tracing (1.507 ms) : 1483, 1531
. : milestone, 1507,
section candidate
no_agent (1.35 ms) : 1330, 1369
. : milestone, 1350,
appsec (1.76 ms) : 1735, 1786
. : milestone, 1760,
appsec_no_iast (1.754 ms) : 1729, 1778
. : milestone, 1754,
iast (1.487 ms) : 1465, 1510
. : milestone, 1487,
profiling (1.51 ms) : 1488, 1533
. : milestone, 1510,
tracing (1.513 ms) : 1489, 1537
. : milestone, 1513,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~e4c4b13fc4, baseline=1.45.0-SNAPSHOT~46b5986f6a
dateFormat X
axisFormat %s
section baseline
no_agent (15.583 s) : 15583000, 15583000
. : milestone, 15583000,
appsec (15.266 s) : 15266000, 15266000
. : milestone, 15266000,
iast (19.071 s) : 19071000, 19071000
. : milestone, 19071000,
iast_GLOBAL (17.931 s) : 17931000, 17931000
. : milestone, 17931000,
profiling (14.955 s) : 14955000, 14955000
. : milestone, 14955000,
tracing (14.87 s) : 14870000, 14870000
. : milestone, 14870000,
section candidate
no_agent (15.457 s) : 15457000, 15457000
. : milestone, 15457000,
appsec (14.688 s) : 14688000, 14688000
. : milestone, 14688000,
iast (19.081 s) : 19081000, 19081000
. : milestone, 19081000,
iast_GLOBAL (17.835 s) : 17835000, 17835000
. : milestone, 17835000,
profiling (15.13 s) : 15130000, 15130000
. : milestone, 15130000,
tracing (14.901 s) : 14901000, 14901000
. : milestone, 14901000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~e4c4b13fc4, baseline=1.45.0-SNAPSHOT~46b5986f6a
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (2.372 ms) : 2330, 2414
. : milestone, 2372,
iast (2.111 ms) : 2058, 2164
. : milestone, 2111,
iast_GLOBAL (2.156 ms) : 2102, 2209
. : milestone, 2156,
profiling (1.967 ms) : 1925, 2009
. : milestone, 1967,
tracing (1.959 ms) : 1918, 1999
. : milestone, 1959,
section candidate
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.355 ms) : 2314, 2396
. : milestone, 2355,
iast (2.103 ms) : 2050, 2156
. : milestone, 2103,
iast_GLOBAL (2.155 ms) : 2102, 2208
. : milestone, 2155,
profiling (1.994 ms) : 1951, 2038
. : milestone, 1994,
tracing (1.949 ms) : 1909, 1990
. : milestone, 1949,
|
What Does This Do
Add the possibility to output the logs of the Java tracer in JSON.
The JSON keys have been chosen to be compatible out of the box with the Logs UI of Datadog.
You will be able to identify all the logs coming from the tracer by filtering them using @origin:dd.trace
Note:
If you don’t configure a specific
datadog.slf4j.simpleLogger.dateTimeFormat
,yyyy-MM-dd'T'HH:mm:ss.SSSZ
to be compatible with the logs UI .[dd.trace 'yyyy-MM-dd HH:mm:ss:SSS Z']
Usage
System property:
datadog.slf4j.simpleLogger.jsonEnabled
Default: false
Description: This configuration key set to true will output the logs of the Java tracer in JSON.
Motivation
#1109
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]