Update the CodeOriginProbe fingerprint to not rely on a stack walk #8016

evanchooly · 2024-11-25T19:01:55Z

What Does This Do

Currently the fingerprinting used to prevent repeat instrumentations uses the stack trace to track existing probe definitions. This PR cleans that up to use a cheaper fingerprint that doesn't rely on walking the stack each time.

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: DEBUG-3147

pr-commenter · 2024-11-25T19:30:50Z

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1732562474	1732562853
end_time	2024-11-25T19:22:29	2024-11-25T19:28:49
git_branch	master	evanchooly/DEBUG-3147
git_commit_sha	`f2d21ae`	`8e7224b`
start_time	2024-11-25T19:21:15	2024-11-25T19:27:34

See matching parameters

	Baseline	Candidate
ci_job_id	719571523	719571523
ci_pipeline_id	49898377	49898377
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1732561828	1732561828

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics.

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-10.715µs; +20.481µs] or [-4.106%; +7.848%]	unstable [-19.164µs; +30.640µs] or [-6.431%; +10.283%]	unstable [-29.799µs; +40.770µs] or [-9.573%; +13.097%]	unstable [-66.855µs; +141.191µs] or [-11.222%; +23.699%]	same
scenario:basic	same	same	same	unstable [-37.533µs; +32.491µs] or [-7.082%; +6.130%]	unstable [-152.251op/s; +152.251op/s] or [-5.938%; +5.938%]
scenario:loop	unsure [-116.208µs; -82.612µs] or [-1.127%; -0.801%]	unsure [-140.557µs; -60.751µs] or [-1.340%; -0.579%]	unsure [-166.011µs; -42.585µs] or [-1.570%; -0.403%]	same	unsure [+0.072op/s; +1.725op/s] or [+0.076%; +1.829%]

Request duration reports for reports

gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (297.98 µs) : 275, 321
.   : milestone, 298,
basic (304.814 µs) : 297, 313
.   : milestone, 305,
loop (10.491 ms) : 10454, 10528
.   : milestone, 10491,
section candidate
noprobe (303.718 µs) : 279, 328
.   : milestone, 304,
basic (303.314 µs) : 294, 313
.   : milestone, 303,
loop (10.39 ms) : 10353, 10428
.   : milestone, 10390,

baseline results

Scenario	Request median duration [CI 0.99]
noprobe	297.98 µs [275.004 µs, 320.956 µs]
basic	304.814 µs [297.119 µs, 312.509 µs]
loop	10.491 ms [10.454 ms, 10.528 ms]

candidate results

Scenario	Request median duration [CI 0.99]
noprobe	303.718 µs [279.221 µs, 328.215 µs]
basic	303.314 µs [293.957 µs, 312.671 µs]
loop	10.39 ms [10.353 ms, 10.428 ms]

pr-commenter · 2024-11-25T19:50:17Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	evanchooly/DEBUG-3147
git_commit_date	1732532650	1732561828
git_commit_sha	`f2d21ae`	`8e7224b`
release_version	1.43.0-SNAPSHOT~f2d21ae588	1.44.0-SNAPSHOT~8e7224b615

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1732564336	1732564336
ci_job_id	719571517	719571517
ci_pipeline_id	49898377	49898377
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~8e7224b615, baseline=1.43.0-SNAPSHOT~f2d21ae588

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.09 s) : 0, 1089633
Total [baseline] (10.458 s) : 0, 10457613
Agent [candidate] (1.111 s) : 0, 1111131
Total [candidate] (10.574 s) : 0, 10574324
section appsec
Agent [baseline] (1.239 s) : 0, 1238577
Total [baseline] (10.789 s) : 0, 10789026
Agent [candidate] (1.225 s) : 0, 1225043
Total [candidate] (10.75 s) : 0, 10750119
section iast
Agent [baseline] (1.223 s) : 0, 1223446
Total [baseline] (10.949 s) : 0, 10949036
Agent [candidate] (1.218 s) : 0, 1218188
Total [candidate] (10.937 s) : 0, 10936808
section profiling
Agent [baseline] (1.317 s) : 0, 1317035
Total [baseline] (10.908 s) : 0, 10908331
Agent [candidate] (1.327 s) : 0, 1327010
Total [candidate] (10.899 s) : 0, 10898522

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.09 s	-
Agent	appsec	1.239 s	148.944 ms (13.7%)
Agent	iast	1.223 s	133.813 ms (12.3%)
Agent	profiling	1.317 s	227.402 ms (20.9%)
Total	tracing	10.458 s	-
Total	appsec	10.789 s	331.413 ms (3.2%)
Total	iast	10.949 s	491.422 ms (4.7%)
Total	profiling	10.908 s	450.717 ms (4.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.111 s	-
Agent	appsec	1.225 s	113.913 ms (10.3%)
Agent	iast	1.218 s	107.057 ms (9.6%)
Agent	profiling	1.327 s	215.879 ms (19.4%)
Total	tracing	10.574 s	-
Total	appsec	10.75 s	175.795 ms (1.7%)
Total	iast	10.937 s	362.484 ms (3.4%)
Total	profiling	10.899 s	324.198 ms (3.1%)

gantt
    title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~8e7224b615, baseline=1.43.0-SNAPSHOT~f2d21ae588

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.223 ms) : 0, 693223
BytebuddyAgent [candidate] (708.103 ms) : 0, 708103
GlobalTracer [baseline] (316.788 ms) : 0, 316788
GlobalTracer [candidate] (323.279 ms) : 0, 323279
AppSec [baseline] (54.675 ms) : 0, 54675
AppSec [candidate] (55.693 ms) : 0, 55693
Remote Config [baseline] (674.659 µs) : 0, 675
Remote Config [candidate] (690.629 µs) : 0, 691
Telemetry [baseline] (10.587 ms) : 0, 10587
Telemetry [candidate] (9.374 ms) : 0, 9374
section appsec
BytebuddyAgent [baseline] (720.356 ms) : 0, 720356
BytebuddyAgent [candidate] (711.645 ms) : 0, 711645
GlobalTracer [baseline] (317.02 ms) : 0, 317020
GlobalTracer [candidate] (313.871 ms) : 0, 313871
AppSec [baseline] (166.745 ms) : 0, 166745
AppSec [candidate] (166.782 ms) : 0, 166782
IAST [baseline] (19.074 ms) : 0, 19074
IAST [candidate] (19.098 ms) : 0, 19098
Remote Config [baseline] (652.906 µs) : 0, 653
Remote Config [candidate] (640.345 µs) : 0, 640
Telemetry [baseline] (10.422 ms) : 0, 10422
Telemetry [candidate] (8.854 ms) : 0, 8854
section iast
BytebuddyAgent [baseline] (815.387 ms) : 0, 815387
BytebuddyAgent [candidate] (811.411 ms) : 0, 811411
GlobalTracer [baseline] (307.2 ms) : 0, 307200
GlobalTracer [candidate] (306.055 ms) : 0, 306055
AppSec [baseline] (58.095 ms) : 0, 58095
AppSec [candidate] (57.325 ms) : 0, 57325
IAST [baseline] (20.801 ms) : 0, 20801
IAST [candidate] (21.554 ms) : 0, 21554
Remote Config [baseline] (633.162 µs) : 0, 633
Remote Config [candidate] (609.477 µs) : 0, 609
Telemetry [baseline] (7.565 ms) : 0, 7565
Telemetry [candidate] (7.525 ms) : 0, 7525
section profiling
BytebuddyAgent [baseline] (687.157 ms) : 0, 687157
BytebuddyAgent [candidate] (696.266 ms) : 0, 696266
GlobalTracer [baseline] (433.475 ms) : 0, 433475
GlobalTracer [candidate] (435.275 ms) : 0, 435275
AppSec [baseline] (54.102 ms) : 0, 54102
AppSec [candidate] (53.775 ms) : 0, 53775
Remote Config [baseline] (673.037 µs) : 0, 673
Remote Config [candidate] (668.46 µs) : 0, 668
Telemetry [baseline] (7.863 ms) : 0, 7863
Telemetry [candidate] (7.766 ms) : 0, 7766
ProfilingAgent [baseline] (94.799 ms) : 0, 94799
ProfilingAgent [candidate] (93.969 ms) : 0, 93969
Profiling [baseline] (94.823 ms) : 0, 94823
Profiling [candidate] (93.993 ms) : 0, 93993

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~8e7224b615, baseline=1.43.0-SNAPSHOT~f2d21ae588

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1088136
Total [baseline] (8.679 s) : 0, 8679169
Agent [candidate] (1.088 s) : 0, 1088481
Total [candidate] (8.644 s) : 0, 8644069
section iast
Agent [baseline] (1.215 s) : 0, 1214983
Total [baseline] (9.179 s) : 0, 9178741
Agent [candidate] (1.217 s) : 0, 1216541
Total [candidate] (9.204 s) : 0, 9204185
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.218 s) : 0, 1217669
Total [baseline] (9.228 s) : 0, 9227923
Agent [candidate] (1.219 s) : 0, 1218535
Total [candidate] (9.149 s) : 0, 9148605
section iast_TELEMETRY_OFF
Agent [baseline] (1.231 s) : 0, 1230863
Total [baseline] (9.258 s) : 0, 9258279
Agent [candidate] (1.214 s) : 0, 1213822
Total [candidate] (9.186 s) : 0, 9186292

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.088 s	-
Agent	iast	1.215 s	126.847 ms (11.7%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.218 s	129.533 ms (11.9%)
Agent	iast_TELEMETRY_OFF	1.231 s	142.727 ms (13.1%)
Total	tracing	8.679 s	-
Total	iast	9.179 s	499.572 ms (5.8%)
Total	iast_HARDCODED_SECRET_DISABLED	9.228 s	548.754 ms (6.3%)
Total	iast_TELEMETRY_OFF	9.258 s	579.11 ms (6.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.088 s	-
Agent	iast	1.217 s	128.06 ms (11.8%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.219 s	130.054 ms (11.9%)
Agent	iast_TELEMETRY_OFF	1.214 s	125.341 ms (11.5%)
Total	tracing	8.644 s	-
Total	iast	9.204 s	560.117 ms (6.5%)
Total	iast_HARDCODED_SECRET_DISABLED	9.149 s	504.536 ms (5.8%)
Total	iast_TELEMETRY_OFF	9.186 s	542.223 ms (6.3%)

gantt
    title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~8e7224b615, baseline=1.43.0-SNAPSHOT~f2d21ae588

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (692.446 ms) : 0, 692446
BytebuddyAgent [candidate] (692.569 ms) : 0, 692569
GlobalTracer [baseline] (316.852 ms) : 0, 316852
GlobalTracer [candidate] (316.817 ms) : 0, 316817
AppSec [baseline] (54.531 ms) : 0, 54531
AppSec [candidate] (54.759 ms) : 0, 54759
Remote Config [baseline] (683.696 µs) : 0, 684
Remote Config [candidate] (689.494 µs) : 0, 689
Telemetry [baseline] (9.927 ms) : 0, 9927
Telemetry [candidate] (9.884 ms) : 0, 9884
section iast
BytebuddyAgent [baseline] (809.411 ms) : 0, 809411
BytebuddyAgent [candidate] (810.461 ms) : 0, 810461
GlobalTracer [baseline] (305.444 ms) : 0, 305444
GlobalTracer [candidate] (305.412 ms) : 0, 305412
AppSec [baseline] (56.83 ms) : 0, 56830
AppSec [candidate] (57.559 ms) : 0, 57559
IAST [baseline] (21.526 ms) : 0, 21526
IAST [candidate] (21.141 ms) : 0, 21141
Remote Config [baseline] (621.958 µs) : 0, 622
Remote Config [candidate] (647.06 µs) : 0, 647
Telemetry [baseline] (7.473 ms) : 0, 7473
Telemetry [candidate] (7.598 ms) : 0, 7598
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (810.307 ms) : 0, 810307
BytebuddyAgent [candidate] (811.679 ms) : 0, 811679
GlobalTracer [baseline] (305.95 ms) : 0, 305950
GlobalTracer [candidate] (306.076 ms) : 0, 306076
AppSec [baseline] (56.964 ms) : 0, 56964
AppSec [candidate] (57.246 ms) : 0, 57246
IAST [baseline] (22.557 ms) : 0, 22557
IAST [candidate] (21.699 ms) : 0, 21699
Remote Config [baseline] (645.726 µs) : 0, 646
Remote Config [candidate] (628.482 µs) : 0, 628
Telemetry [baseline] (7.554 ms) : 0, 7554
Telemetry [candidate] (7.5 ms) : 0, 7500
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (820.106 ms) : 0, 820106
BytebuddyAgent [candidate] (808.242 ms) : 0, 808242
GlobalTracer [baseline] (309.417 ms) : 0, 309417
GlobalTracer [candidate] (305.489 ms) : 0, 305489
AppSec [baseline] (56.777 ms) : 0, 56777
AppSec [candidate] (58.144 ms) : 0, 58144
IAST [baseline] (22.533 ms) : 0, 22533
IAST [candidate] (20.207 ms) : 0, 20207
Remote Config [baseline] (653.842 µs) : 0, 654
Remote Config [candidate] (614.197 µs) : 0, 614
Telemetry [baseline] (7.517 ms) : 0, 7517
Telemetry [candidate] (7.395 ms) : 0, 7395

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-11-25T19:22:20	2024-11-25T19:29:19
git_branch	master	evanchooly/DEBUG-3147
git_commit_date	1732532650	1732561828
git_commit_sha	`f2d21ae`	`8e7224b`
release_version	1.43.0-SNAPSHOT~f2d21ae588	1.44.0-SNAPSHOT~8e7224b615
start_time	2024-11-25T19:22:07	2024-11-25T19:29:05

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1732563312	1732563312
ci_job_id	719571518	719571518
ci_pipeline_id	49898377	49898377
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:petclinic:profiling	better [-84.072µs; -32.824µs] or [-5.354%; -2.090%]	unstable [-437.300op/s; +665.221op/s] or [-14.759%; +22.451%]	1.512ms	3076.923op/s	1.570ms	2962.963op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~8e7224b615, baseline=1.43.0-SNAPSHOT~f2d21ae588
    dateFormat X
    axisFormat %s
section baseline
no_agent (369.831 µs) : 350, 390
.   : milestone, 370,
iast (492.396 µs) : 470, 515
.   : milestone, 492,
iast_FULL (643.5 µs) : 622, 665
.   : milestone, 643,
iast_GLOBAL (513.83 µs) : 493, 535
.   : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (485.95 µs) : 465, 507
.   : milestone, 486,
iast_INACTIVE (440.615 µs) : 420, 461
.   : milestone, 441,
iast_TELEMETRY_OFF (473.013 µs) : 451, 495
.   : milestone, 473,
tracing (443.031 µs) : 422, 464
.   : milestone, 443,
section candidate
no_agent (372.396 µs) : 353, 392
.   : milestone, 372,
iast (490.695 µs) : 468, 513
.   : milestone, 491,
iast_FULL (644.314 µs) : 623, 666
.   : milestone, 644,
iast_GLOBAL (523.763 µs) : 501, 547
.   : milestone, 524,
iast_HARDCODED_SECRET_DISABLED (493.2 µs) : 472, 515
.   : milestone, 493,
iast_INACTIVE (455.611 µs) : 434, 478
.   : milestone, 456,
iast_TELEMETRY_OFF (474.043 µs) : 453, 495
.   : milestone, 474,
tracing (443.6 µs) : 422, 465
.   : milestone, 444,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	369.831 µs [349.988 µs, 389.673 µs]	-
iast	492.396 µs [470.282 µs, 514.511 µs]	122.566 µs (33.1%)
iast_FULL	643.5 µs [622.0 µs, 664.999 µs]	273.669 µs (74.0%)
iast_GLOBAL	513.83 µs [492.527 µs, 535.134 µs]	144.0 µs (38.9%)
iast_HARDCODED_SECRET_DISABLED	485.95 µs [464.505 µs, 507.395 µs]	116.12 µs (31.4%)
iast_INACTIVE	440.615 µs [419.985 µs, 461.245 µs]	70.784 µs (19.1%)
iast_TELEMETRY_OFF	473.013 µs [451.369 µs, 494.656 µs]	103.182 µs (27.9%)
tracing	443.031 µs [422.163 µs, 463.899 µs]	73.201 µs (19.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	372.396 µs [352.675 µs, 392.116 µs]	-
iast	490.695 µs [468.442 µs, 512.949 µs]	118.299 µs (31.8%)
iast_FULL	644.314 µs [622.508 µs, 666.12 µs]	271.918 µs (73.0%)
iast_GLOBAL	523.763 µs [500.689 µs, 546.836 µs]	151.367 µs (40.6%)
iast_HARDCODED_SECRET_DISABLED	493.2 µs [471.592 µs, 514.808 µs]	120.804 µs (32.4%)
iast_INACTIVE	455.611 µs [433.715 µs, 477.508 µs]	83.216 µs (22.3%)
iast_TELEMETRY_OFF	474.043 µs [452.609 µs, 495.477 µs]	101.647 µs (27.3%)
tracing	443.6 µs [422.47 µs, 464.73 µs]	71.204 µs (19.1%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~8e7224b615, baseline=1.43.0-SNAPSHOT~f2d21ae588
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.359 ms) : 1339, 1378
.   : milestone, 1359,
appsec (1.752 ms) : 1727, 1776
.   : milestone, 1752,
appsec_no_iast (1.759 ms) : 1734, 1785
.   : milestone, 1759,
iast (1.481 ms) : 1458, 1504
.   : milestone, 1481,
profiling (1.57 ms) : 1545, 1595
.   : milestone, 1570,
tracing (1.486 ms) : 1463, 1510
.   : milestone, 1486,
section candidate
no_agent (1.35 ms) : 1331, 1369
.   : milestone, 1350,
appsec (1.778 ms) : 1754, 1803
.   : milestone, 1778,
appsec_no_iast (1.755 ms) : 1731, 1780
.   : milestone, 1755,
iast (1.504 ms) : 1482, 1527
.   : milestone, 1504,
profiling (1.512 ms) : 1489, 1534
.   : milestone, 1512,
tracing (1.502 ms) : 1477, 1526
.   : milestone, 1502,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.359 ms [1.339 ms, 1.378 ms]	-
appsec	1.752 ms [1.727 ms, 1.776 ms]	393.176 µs (28.9%)
appsec_no_iast	1.759 ms [1.734 ms, 1.785 ms]	400.79 µs (29.5%)
iast	1.481 ms [1.458 ms, 1.504 ms]	121.989 µs (9.0%)
profiling	1.57 ms [1.545 ms, 1.595 ms]	211.782 µs (15.6%)
tracing	1.486 ms [1.463 ms, 1.51 ms]	127.829 µs (9.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.35 ms [1.331 ms, 1.369 ms]	-
appsec	1.778 ms [1.754 ms, 1.803 ms]	428.605 µs (31.8%)
appsec_no_iast	1.755 ms [1.731 ms, 1.78 ms]	405.604 µs (30.1%)
iast	1.504 ms [1.482 ms, 1.527 ms]	154.521 µs (11.4%)
profiling	1.512 ms [1.489 ms, 1.534 ms]	162.218 µs (12.0%)
tracing	1.502 ms [1.477 ms, 1.526 ms]	151.862 µs (11.3%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	evanchooly/DEBUG-3147
git_commit_date	1732532650	1732561828
git_commit_sha	`f2d21ae`	`8e7224b`
release_version	1.43.0-SNAPSHOT~f2d21ae588	1.44.0-SNAPSHOT~8e7224b615

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1732563871	1732563871
ci_job_id	719571519	719571519
ci_pipeline_id	49898377	49898377
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~8e7224b615, baseline=1.43.0-SNAPSHOT~f2d21ae588
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.64 s) : 15640000, 15640000
.   : milestone, 15640000,
appsec (15.069 s) : 15069000, 15069000
.   : milestone, 15069000,
iast (18.6 s) : 18600000, 18600000
.   : milestone, 18600000,
iast_GLOBAL (18.3 s) : 18300000, 18300000
.   : milestone, 18300000,
profiling (14.876 s) : 14876000, 14876000
.   : milestone, 14876000,
tracing (15.379 s) : 15379000, 15379000
.   : milestone, 15379000,
section candidate
no_agent (14.916 s) : 14916000, 14916000
.   : milestone, 14916000,
appsec (14.865 s) : 14865000, 14865000
.   : milestone, 14865000,
iast (18.512 s) : 18512000, 18512000
.   : milestone, 18512000,
iast_GLOBAL (18.153 s) : 18153000, 18153000
.   : milestone, 18153000,
profiling (15.147 s) : 15147000, 15147000
.   : milestone, 15147000,
tracing (14.964 s) : 14964000, 14964000
.   : milestone, 14964000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.64 s [15.64 s, 15.64 s]	-
appsec	15.069 s [15.069 s, 15.069 s]	-571.0 ms (-3.7%)
iast	18.6 s [18.6 s, 18.6 s]	2.96 s (18.9%)
iast_GLOBAL	18.3 s [18.3 s, 18.3 s]	2.66 s (17.0%)
profiling	14.876 s [14.876 s, 14.876 s]	-764.0 ms (-4.9%)
tracing	15.379 s [15.379 s, 15.379 s]	-261.0 ms (-1.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.916 s [14.916 s, 14.916 s]	-
appsec	14.865 s [14.865 s, 14.865 s]	-51.0 ms (-0.3%)
iast	18.512 s [18.512 s, 18.512 s]	3.596 s (24.1%)
iast_GLOBAL	18.153 s [18.153 s, 18.153 s]	3.237 s (21.7%)
profiling	15.147 s [15.147 s, 15.147 s]	231.0 ms (1.5%)
tracing	14.964 s [14.964 s, 14.964 s]	48.0 ms (0.3%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~8e7224b615, baseline=1.43.0-SNAPSHOT~f2d21ae588
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
.   : milestone, 1469,
appsec (2.361 ms) : 2319, 2402
.   : milestone, 2361,
iast (2.092 ms) : 2040, 2144
.   : milestone, 2092,
iast_GLOBAL (2.148 ms) : 2095, 2201
.   : milestone, 2148,
profiling (1.974 ms) : 1931, 2017
.   : milestone, 1974,
tracing (1.931 ms) : 1891, 1972
.   : milestone, 1931,
section candidate
no_agent (1.47 ms) : 1458, 1481
.   : milestone, 1470,
appsec (2.357 ms) : 2315, 2398
.   : milestone, 2357,
iast (2.093 ms) : 2041, 2146
.   : milestone, 2093,
iast_GLOBAL (2.13 ms) : 2078, 2183
.   : milestone, 2130,
profiling (1.949 ms) : 1907, 1990
.   : milestone, 1949,
tracing (1.936 ms) : 1896, 1977
.   : milestone, 1936,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.469 ms [1.458 ms, 1.481 ms]	-
appsec	2.361 ms [2.319 ms, 2.402 ms]	891.731 µs (60.7%)
iast	2.092 ms [2.04 ms, 2.144 ms]	622.82 µs (42.4%)
iast_GLOBAL	2.148 ms [2.095 ms, 2.201 ms]	678.861 µs (46.2%)
profiling	1.974 ms [1.931 ms, 2.017 ms]	504.475 µs (34.3%)
tracing	1.931 ms [1.891 ms, 1.972 ms]	462.195 µs (31.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.47 ms [1.458 ms, 1.481 ms]	-
appsec	2.357 ms [2.315 ms, 2.398 ms]	886.872 µs (60.3%)
iast	2.093 ms [2.041 ms, 2.146 ms]	623.316 µs (42.4%)
iast_GLOBAL	2.13 ms [2.078 ms, 2.183 ms]	660.559 µs (44.9%)
profiling	1.949 ms [1.907 ms, 1.99 ms]	478.695 µs (32.6%)
tracing	1.936 ms [1.896 ms, 1.977 ms]	466.436 µs (31.7%)

jpbempel · 2024-11-27T10:22:40Z

...gger-bootstrap/src/main/java/datadog/trace/bootstrap/debugger/spanorigin/CodeOriginInfo.java

      if (span != null) {
-        span.getLocalRootSpan().setTag(probeId, span);
+        span.getLocalRootSpan().setTag(probeId, span.getSpanId());


This changes introduces a bug because here we are expecting a span while we have only an span id

…8016)

github-actions · 2024-12-05T12:46:39Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.49.0` -> `2.50.0` | | [com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.48.0` -> `2.49.0` | | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.82.0` -> `6.83.0` | | [com.google.cloud:google-cloud-logging](https://github.com/googleapis/java-logging) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.20.7` -> `3.21.0` | | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.24.3` -> `2.25.1` | | [com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.48.0` -> `2.49.0` | | [com.google.api:gax](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.58.0` -> `2.59.0` | | [com.autonomousapps.dependency-analysis](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `2.6.0` -> `2.6.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.43.0` -> `1.44.1` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.43.0` -> `1.44.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [com.amazonaws:aws-java-sdk-sqs](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-s3](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-dynamodb](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-core](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | --- ### Release Notes <details> <summary>googleapis/sdk-platform-java (com.google.api.grpc:proto-google-common-protos)</summary> ### [`v2.50.0`](https://github.com/googleapis/sdk-platform-java/blob/HEAD/CHANGELOG.md#2500-2024-11-14) ##### Features - Add experimental S2A integration in client libraries grpc transport ([#3326](googleapis/sdk-platform-java#3326)) ([1138ca6](googleapis/sdk-platform-java@1138ca6)) - enable selective generation based on service config include list ([#3323](googleapis/sdk-platform-java#3323)) ([0cddadb](googleapis/sdk-platform-java@0cddadb)) - introduce `java.time` to java-core ([#3330](googleapis/sdk-platform-java#3330)) ([f202c3b](googleapis/sdk-platform-java@f202c3b)) - Update Gapic-Generator to generate libraries using `java.time` methods ([#3321](googleapis/sdk-platform-java#3321)) ([b21c9a4](googleapis/sdk-platform-java@b21c9a4)) ##### Bug Fixes - Fix flaky test ScheduledRetryingExecutorTest.testCancelOuterFutureAfterStart ([#3335](googleapis/sdk-platform-java#3335)) ([e73740d](googleapis/sdk-platform-java@e73740d)) - httpjson callables to trace attempts (started, failed) ([#3300](googleapis/sdk-platform-java#3300)) ([15a64ee](googleapis/sdk-platform-java@15a64ee)) - instantiate GaxProperties at build time to ensure we get the protobuf version ([#3365](googleapis/sdk-platform-java#3365)) ([bb2a3be](googleapis/sdk-platform-java@bb2a3be)) - protobuf version not always getting set in headers ([#3322](googleapis/sdk-platform-java#3322)) ([7f6e470](googleapis/sdk-platform-java@7f6e470)) - use BuildKit instead of legacy builder to build the Hermetic Build images ([#3338](googleapis/sdk-platform-java#3338)) ([222fb45](googleapis/sdk-platform-java@222fb45)) ##### Dependencies - update google auth library dependencies to v1.30.0 ([#3367](googleapis/sdk-platform-java#3367)) ([a31c682](googleapis/sdk-platform-java@a31c682)) - update grpc dependencies to v1.68.1 ([#3240](googleapis/sdk-platform-java#3240)) ([c8e3941](googleapis/sdk-platform-java@c8e3941)) ##### Documentation - fix list num ([#3356](googleapis/sdk-platform-java#3356)) ([b7d6296](googleapis/sdk-platform-java@b7d6296)) - **hermetic-build:** indicate usage of Docker Buildkit in development guide ([#3337](googleapis/sdk-platform-java#3337)) ([01e742d](googleapis/sdk-platform-java@01e742d)) - modify hermetic build docs ([#3331](googleapis/sdk-platform-java#3331)) ([25023af](googleapis/sdk-platform-java@25023af)) </details> <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.83.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6830-2024-12-13) ##### Features - Add Metrics host for built in metrics ([#3519](googleapis/java-spanner#3519)) ([4ed455a](googleapis/java-spanner@4ed455a)) - Add opt-in for using multiplexed sessions for blind writes ([#3540](googleapis/java-spanner#3540)) ([216f53e](googleapis/java-spanner@216f53e)) - Add UUID in Spanner TypeCode enum ([41f83dc](googleapis/java-spanner@41f83dc)) - Introduce java.time variables and methods ([#3495](googleapis/java-spanner#3495)) ([8a7d533](googleapis/java-spanner@8a7d533)) - **spanner:** Support multiplexed session for Partitioned operations ([#3231](googleapis/java-spanner#3231)) ([4501a3e](googleapis/java-spanner@4501a3e)) - Support 'set local' for retry_aborts_internally ([#3532](googleapis/java-spanner#3532)) ([331942f](googleapis/java-spanner@331942f)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([41f83dc](googleapis/java-spanner@41f83dc)) ##### Dependencies - Update sdk platform java dependencies ([#3549](googleapis/java-spanner#3549)) ([6235f0f](googleapis/java-spanner@6235f0f)) </details> <details> <summary>googleapis/java-logging (com.google.cloud:google-cloud-logging)</summary> ### [`v3.21.0`](https://github.com/googleapis/java-logging/blob/HEAD/CHANGELOG.md#3210-2024-12-13) ##### Features - Introduce `java.time` methods ([#1729](googleapis/java-logging#1729)) ([323eb33](googleapis/java-logging@323eb33)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([04d8868](googleapis/java-logging@04d8868)) ##### Dependencies - Update dependency io.opentelemetry:opentelemetry-bom to v1.45.0 ([#1638](googleapis/java-logging#1638)) ([7e007d4](googleapis/java-logging@7e007d4)) - Update sdk platform java dependencies ([#1736](googleapis/java-logging#1736)) ([88b4cdf](googleapis/java-logging@88b4cdf)) </details> <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.25.1`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2251-2024-12-13) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([106ee4d](googleapis/java-datastore@106ee4d)) ##### Dependencies - Update sdk platform java dependencies ([#1685](googleapis/java-datastore#1685)) ([4372350](googleapis/java-datastore@4372350)) ### [`v2.25.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2250-2024-12-11) ##### Features - Introduce `java.time` methods and variables ([#1671](googleapis/java-datastore#1671)) ([5a78a80](googleapis/java-datastore@5a78a80)) ##### Dependencies - Update dependency com.google.cloud:gapic-libraries-bom to v1.48.0 ([#1605](googleapis/java-datastore#1605)) ([5c6a678](googleapis/java-datastore@5c6a678)) ##### Documentation - Update gapic upgrade installation instructions ([#1677](googleapis/java-datastore#1677)) ([b3fbfcc](googleapis/java-datastore@b3fbfcc)) </details> <details> <summary>autonomousapps/dependency-analysis-android-gradle-plugin (com.autonomousapps.dependency-analysis)</summary> ### [`v2.6.1`](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/blob/HEAD/CHANGELOG.md#Version-261) - \[Fix]: `superClassName` can be null (Object has no superclass). </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.44.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.44.1): 1.44.1 ##### Components ##### Continuous Integration Visibility - 🐛 Fix tracing JUnit5 tests in Maven projects with multiple forks ([#8089](DataDog/dd-trace-java#8089) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ### [`v1.44.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.44.0): 1.44.0 ##### Known Issues > \[!WARNING]\ > This release contains a known issue that causes failures when using Test Optimization to trace JUnit 5 tests in a Maven project where Maven Surefire is configured with `forkCount` > 1. > The issue is fixed in v1.44.1 ##### Breaking Changes > \[!WARNING]\ > Support for `X-Forwarded` header is dropped from default client IP resolution. > It can still be re-activated using the `dd.trace.client-ip-header=x-forwarded` system property, or the `DD_TRACE_CLIENT_IP_HEADER=x-forwarded` environment variable. See [#7946](DataDog/dd-trace-java#7946). ##### Components ##### Application Security Management (IAST) - ✨ Set unexpected IAST exceptions to debug log level ([#8044](DataDog/dd-trace-java#8044) - [@smola](https://github.com/smola)) - ✨ Increase IAST propagation to StringBuffer subSequence ([#8038](DataDog/dd-trace-java#8038) - [@Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuilder subSequence ([#8026](DataDog/dd-trace-java#8026) - [@Mariovido](https://github.com/Mariovido)) - ✨ Add IAST propagation to String valueOf ([#8013](DataDog/dd-trace-java#8013) - [@Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuilder append ([#8010](DataDog/dd-trace-java#8010) - [@Mariovido](https://github.com/Mariovido)) - ✨ Expand SSRF support in IAST to apache-httpclient-5 and apache-httpasyncclient-4 ([#7920](DataDog/dd-trace-java#7920) - [@Mariovido](https://github.com/Mariovido)) ##### Build & Tooling - ✨ Generate Muzzle classes for Groovy instrumentations ([#8004](DataDog/dd-trace-java#8004) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Continuous Integration Visibility - ✨ Support distributed traces in tests ([#8078](DataDog/dd-trace-java#8078) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement fail-fast tests ordering for JUnit 5 ([#8055](DataDog/dd-trace-java#8055) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Mark JUnit 5 setup and teardown action spans as failed if there is an error ([#8033](DataDog/dd-trace-java#8033) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tracing of setup and teardown actions in JUnit 4 ([#8030](DataDog/dd-trace-java#8030) - [@daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Improve crash tracking install logging ([#8045](DataDog/dd-trace-java#8045) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Data Streams Monitoring - 🐛 Add Data Streams support in AWS SQS without raw message delivery ([#8071](DataDog/dd-trace-java#8071) - [@piochelepiotr](https://github.com/piochelepiotr)) - ✨ Add new tag for enabled products / features to DSM checkpoints ([#8051](DataDog/dd-trace-java#8051) - [@kr-igor](https://github.com/kr-igor)) - 💡 Instrument self hosted Kafka connectors ([#7959](DataDog/dd-trace-java#7959) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### Dynamic Instrumentation - ✨ Add Micronaut 4 support for code origin for spans ([#8039](DataDog/dd-trace-java#8039) - [@jpbempel](https://github.com/jpbempel)) - ✨ Refactor probe matching for methods ([#8021](DataDog/dd-trace-java#8021) - [@jpbempel](https://github.com/jpbempel)) - ✨ Update the CodeOriginProbe fingerprint to not rely on a stack walk ([#8016](DataDog/dd-trace-java#8016) - [@evanchooly](https://github.com/evanchooly)) - ✨ Implement code origin support for grpc server entry spans ([#7942](DataDog/dd-trace-java#7942) - [@evanchooly](https://github.com/evanchooly)) ##### GraalVM native-image - 🐛 Update Graal build-time instrumentation config for TracePropagationStyle ([#8065](DataDog/dd-trace-java#8065) - [@MattAlp](https://github.com/MattAlp)) - 🐛 Fix NoClassDefFoundError: Could not initialize class DDSpanLink$EncoderHolder in Graal native-image ([#8036](DataDog/dd-trace-java#8036) - [@mcculls](https://github.com/mcculls)) - 🐛🧹 Fix native-image generation of reactive applications ([#8012](DataDog/dd-trace-java#8012) - [@mcculls](https://github.com/mcculls)) ##### OpenTracing - 🧹 Custom ScopeManagers are deprecated and will be removed in a future release of dd-trace-ot ([#8058](DataDog/dd-trace-java#8058) - [@mcculls](https://github.com/mcculls)) ##### Tracer core - ✨🧪 Service naming: split by jee deployment ([#8064](DataDog/dd-trace-java#8064) - [@amarziali](https://github.com/amarziali)) - ✨ Exclude jboss mdb proxies from instrumenting ([#8061](DataDog/dd-trace-java#8061) - [@amarziali](https://github.com/amarziali)) - ✨ Add a built-in trace interceptor for keeping traces depending of their latency ([#8040](DataDog/dd-trace-java#8040) - [@cecile75](https://github.com/cecile75)) - 💡 Introduce marker mechanism for eagerly initializing helpers ([#8028](DataDog/dd-trace-java#8028) - [@mcculls](https://github.com/mcculls)) - 💡 Add JSON component ([#7973](DataDog/dd-trace-java#7973) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨⚠️ Remove support for X-Forwarded in client IP resolution ([#7946](DataDog/dd-trace-java#7946) - [@smola](https://github.com/smola)) ##### Instrumentations ##### Apache HttpComponents - ✨ Expand SSRF support in IAST to apache-httpclient-5 and apache-httpasyncclient-4 ([#7920](DataDog/dd-trace-java#7920) - [@Mariovido](https://github.com/Mariovido)) ##### gRPC instrumentation - 🐛 Use lower priorities for grpc server errors ([#8043](DataDog/dd-trace-java#8043) - [@amarziali](https://github.com/amarziali)) ##### JDBC instrumentation - ✨ Add trace injection for prepared statements in Postgres ([#7940](DataDog/dd-trace-java#7940) - [@nenadnoveljic](https://github.com/nenadnoveljic)) ##### JMS instrumentation - 🐛 Protect mdb from instrumenting multiple time the same event ([#8062](DataDog/dd-trace-java#8062) - [@amarziali](https://github.com/amarziali)) ##### Kafka instrumentation - 💡 Instrument self hosted Kafka connectors ([#7959](DataDog/dd-trace-java#7959) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### OpenTelemetry instrumentation - 🐛 Support using OpenTelemetry Event API inside `@WithSpan` annotated method ([#8019](DataDog/dd-trace-java#8019) - [@mcculls](https://github.com/mcculls)) ##### Reactor instrumentation - 🐛🧹 Fix native-image generation of reactive applications ([#8012](DataDog/dd-trace-java#8012) - [@mcculls](https://github.com/mcculls)) ##### Spring instrumentation - 🐛 Avoid double instrumenting lambdas on latest spring scheduling ([#8005](DataDog/dd-trace-java#8005) - [@amarziali](https://github.com/amarziali)) ##### All other instrumentations - 🐛 Twilio: allow service name flattening ([#8025](DataDog/dd-trace-java#8025) - [@amarziali](https://github.com/amarziali)) - ✨ Instrument Mulesoft 4.5.0+ ([#7981](DataDog/dd-trace-java#7981) - [@amarziali](https://github.com/amarziali)) </details> <details> <summary>aws/aws-sdk-java (com.amazonaws:aws-java-sdk-sqs)</summary> ### [`v1.12.780`](https://github.com/aws/aws-sdk-java/blob/HEAD/CHANGELOG.md#112780-2024-12-11) [Compare Source](aws/aws-sdk-java@1.12.779...1.12.780) #### **Amazon Simple Storage Service** - ### Bugfixes - AWS SDK for Java 1.x now includes additional validation for Amazon S3 client APIs to handle scenarios where an empty string ('') is passed as the key argument to the following operations: PutObject, DeleteObject, ListObjects, GetObjectMetaData, ListObjectsV2, SetObjectTagging, GetObjectTagging, SetObjectAcl, GetObjectAcl, SetObjectLegalHold, GetObjectLegalHold, CopyObject, CopyPart, SelectObjectContent, SetObjectRetention, GetObjectRetention, AbortMultipartUpload, CompleteMultipartUpload, InitiateMultipartUpload, ListParts, UploadPart, RestoreObjectV2, and RestoreObject. The SDK will validate the key argument and throw an exception if it is an empty string, ensuring correct and expected behavior. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 69831bc62ea4d80cdcd42cef2aa9bd8eda28ae8c

Update fingerprinting to be a touch more efficient

8e7224b

evanchooly force-pushed the evanchooly/DEBUG-3147 branch from 716a675 to 8e7224b Compare November 25, 2024 19:11

evanchooly requested a review from jpbempel November 25, 2024 19:11

evanchooly marked this pull request as ready for review November 25, 2024 19:11

evanchooly requested a review from a team as a code owner November 25, 2024 19:11

evanchooly enabled auto-merge (squash) November 25, 2024 19:57

jpbempel approved these changes Nov 26, 2024

View reviewed changes

evanchooly merged commit ac4977a into master Nov 26, 2024
103 checks passed

evanchooly deleted the evanchooly/DEBUG-3147 branch November 26, 2024 17:18

github-actions bot added this to the 1.44.0 milestone Nov 26, 2024

jpbempel reviewed Nov 27, 2024

View reviewed changes

PerfectSlayer pushed a commit that referenced this pull request Nov 28, 2024

Update the CodeOriginProbe fingerprint to not rely on a stack walk (#…

8c921d8

…8016)

jpbempel added the comp: debugger Dynamic Instrumentation label Dec 5, 2024

jpbempel added the type: enhancement label Dec 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the CodeOriginProbe fingerprint to not rely on a stack walk #8016

Update the CodeOriginProbe fingerprint to not rely on a stack walk #8016

evanchooly commented Nov 25, 2024 •

edited by jira bot

Loading

pr-commenter bot commented Nov 25, 2024 •

edited

Loading

pr-commenter bot commented Nov 25, 2024 •

edited

Loading

jpbempel Nov 27, 2024

github-actions bot commented Dec 5, 2024

Update the CodeOriginProbe fingerprint to not rely on a stack walk #8016

Update the CodeOriginProbe fingerprint to not rely on a stack walk #8016

Conversation

evanchooly commented Nov 25, 2024 • edited by jira bot Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Nov 25, 2024 • edited Loading

Debugger benchmarks

Parameters

Summary

pr-commenter bot commented Nov 25, 2024 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

jpbempel Nov 27, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 5, 2024

evanchooly commented Nov 25, 2024 •

edited by jira bot

Loading

pr-commenter bot commented Nov 25, 2024 •

edited

Loading

pr-commenter bot commented Nov 25, 2024 •

edited

Loading