Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new set of test streams from Axinom #3803

Conversation

mesikapp
Copy link
Contributor

@mesikapp mesikapp commented Nov 4, 2021

Added set of new test vectors (12 in total)
4x non-encrypted
4x cbcs encrypted
4x cenc encrypted

@dsilhavy dsilhavy added this to the 4.1.1 milestone Nov 4, 2021
@dsilhavy
Copy link
Collaborator

dsilhavy commented Nov 5, 2021

@mesikapp Thanks for the new streams. As this is an official pull request I would kindly ask you/Axinom to check our CLA:

Following our contribution guidelines, and since this seems to be your first PR, could you please send me a signed copy of dash.js feedback agreement?

@dsilhavy dsilhavy modified the milestones: 4.2.0, 4.3.0 Nov 19, 2021
@dsilhavy
Copy link
Collaborator

@mesikapp Any updates here? Is it possible to sign the contributors agreement?

@mesikapp
Copy link
Contributor Author

@dsilhavy Hey! Yes i have signed the feedbck agreement. I sent it to [email protected] as this was the only contact i found.
Did not want to attach it directly here, but if needed be i can also add it here.

@dsilhavy
Copy link
Collaborator

@mesikapp Thanks all good then

@dsilhavy
Copy link
Collaborator

@mesikapp Can you please quickly rebase your changes against the latest development branch

@mesikapp
Copy link
Contributor Author

mesikapp commented Dec 1, 2021

@dsilhavy Rebase done and i hope i managed to do it correctly/successfully
Thanks!

@dsilhavy
Copy link
Collaborator

dsilhavy commented Dec 1, 2021

@mesikapp Thanks for some reason I see the previous commits which are already merged in the change list as well. Not sure if this will mess up the commit history. Can I therefore ask you to create a new PR based on the current development branch only including your changes to the sources.json. Sorry for the confusion

@mesikapp
Copy link
Contributor Author

mesikapp commented Dec 1, 2021

@dsilhavy Not a problem, at least i got some valuable life lessons regarding merge & rebase.
Creatd new PR
I guess this one can now be closed/rejcted/removed

@mesikapp
Copy link
Contributor Author

mesikapp commented Dec 1, 2021

Closing this PR due to it beeing now obsolite and having possible conflicts. New PR with same changes was successfully merged

@mesikapp mesikapp closed this Dec 1, 2021
@mesikapp mesikapp deleted the new-test-vectors-set-from-axinom branch December 1, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants