Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor message reassembly to handle multiple messages in a single packet #160

Merged
merged 10 commits into from
Nov 14, 2021

Conversation

bdraco
Copy link
Collaborator

@bdraco bdraco commented Nov 14, 2021

  • Ensure multiple responses are split and processed

- Ensure multiple responses are split and processed
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2021

Codecov Report

Merging #160 (f6a2c8d) into master (e671f58) will increase coverage by 8.22%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
+ Coverage   45.87%   54.10%   +8.22%     
==========================================
  Files          16       16              
  Lines        2075     2072       -3     
==========================================
+ Hits          952     1121     +169     
+ Misses       1123      951     -172     
Impacted Files Coverage Δ
flux_led/protocol.py 82.47% <77.77%> (+2.05%) ⬆️
flux_led/aiodevice.py 80.60% <100.00%> (+80.60%) ⬆️
flux_led/base_device.py 87.98% <0.00%> (+0.48%) ⬆️
flux_led/aio.py 100.00% <0.00%> (+100.00%) ⬆️
flux_led/aioprotocol.py 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e671f58...f6a2c8d. Read the comment docs.

@bdraco bdraco changed the title Refactor message reassembly Refactor message reassembly to handle multiple messages in a single packet Nov 14, 2021
@bdraco bdraco marked this pull request as ready for review November 14, 2021 17:21
@bdraco bdraco merged commit 7b91347 into Danielhiversen:master Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants