Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #4 - update generator to support autocompleting kafka commands that end with ".sh" #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix #4 - update generator to support autocompleting kafka commands that end with ".sh" #5

wants to merge 1 commit into from

Conversation

atsu85
Copy link

@atsu85 atsu85 commented Aug 14, 2021

resolves #4

This PR makes autocomplete work also when hitting tab after
kafka-console-producer.sh --

that developers may want to use when command name itself is autocompleted based on file name present in the OS $PATH

not only after
kafka-console-producer --
that was supported previously

@atsu85 atsu85 mentioned this pull request Aug 14, 2021
Open
@atsu85
Copy link
Author

atsu85 commented Aug 14, 2021

Note that others have tried to work around the same issue with different approaches:

  • @AndreaTosti only updated the generated file with this commit, not the generator itself as in this PR
  • @bioker added a workaround instructions with this commit that made copies of all kafka sh scripts without sh extension, so that OS would suggest command names without ".sh" extension when command is in OS $PATH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make autocomplete work even if ".sh" is appended to the command name
1 participant
@atsu85