Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Exposing more props to renderPane for EditorTab #759

Merged
merged 3 commits into from
Jun 8, 2022

Conversation

Zaoei
Copy link
Collaborator

@Zaoei Zaoei commented Jun 2, 2022

Description

exposing more props to renderPane for EditorTab

Fixes #649

Changes

  • tab.renderPane method arguments add tab and group
  • add renderPane example

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #759 (ef2d66a) into main (4c09eea) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #759      +/-   ##
==========================================
+ Coverage   91.41%   91.46%   +0.04%     
==========================================
  Files         189      191       +2     
  Lines        5973     5984      +11     
  Branches     1438     1440       +2     
==========================================
+ Hits         5460     5473      +13     
+ Misses        506      505       -1     
+ Partials        7        6       -1     
Impacted Files Coverage Δ
src/components/tabs/tab.tsx 100.00% <ø> (ø)
src/workbench/editor/editor.tsx 86.36% <ø> (ø)
src/workbench/editor/group.tsx 94.59% <100.00%> (+8.10%) ⬆️
src/controller/settings.tsx 96.15% <0.00%> (-3.85%) ⬇️
src/molecule.api.ts 100.00% <0.00%> (ø)
src/i18n/localeService.ts 100.00% <0.00%> (ø)
src/provider/molecule.tsx 100.00% <0.00%> (ø)
src/model/workbench/explorer/explorer.tsx 100.00% <0.00%> (ø)
src/workbench/sidebar/explore/explore.tsx 80.00% <0.00%> (ø)
src/services/workbench/explorer/explorerService.ts 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c09eea...ef2d66a. Read the comment docs.

@Zaoei Zaoei requested review from mortalYoung, wewoor and mumiao June 2, 2022 15:13
@Zaoei Zaoei self-assigned this Jun 2, 2022
@Zaoei Zaoei changed the title Feat/tab render pane arg feat:Exposing more props to renderPane for EditorTab Jun 2, 2022
@Zaoei Zaoei added the feature label Jun 2, 2022
Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Zaoei Zaoei force-pushed the feat/tab_renderPane_arg branch from f5906a8 to ef2d66a Compare June 7, 2022 13:02
@Zaoei Zaoei added this to the 0.9.0-beta.5 milestone Jun 7, 2022
Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 7682179 into DTStack:main Jun 8, 2022
@wewoor wewoor mentioned this pull request Jun 17, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat:Exposing more props to renderPane for EditorTab
3 participants